764114 - Copy also bin/ssltunnel binary along with xpcshell binary to the target bin dir when running xpcshell

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Honza Bambas (:mayhemer)]

This is needed to allow testing of ssl/tls with xpcshell.  The binary of ssltunnel cannot be easily located by the harness unless copied along with xpcshell binary.

Maybe this belongs to the XPCShell Harness component?

Comment 1

[(not currently active) Ted Mielczarek]

Turns out to be a RelEng bug.

Comment 2

[Chris AtLee [:catlee]]

Looks like http://hg.mozilla.org/build/buildbotcustom/file/4f4db9eab115/steps/unittest.py#l751 needs updating

Comment 3

[Honza Bambas (:mayhemer)]

Is there an ETA?

Comment 4

[Honza Bambas (:mayhemer)]

If I have a patch for that script, who should review it and what are next steps after it is r+'ed?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Anyone who's reviewed changes in the same file is fine. Depending on the change it may need to go through the staging system first.

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 7

[Chris AtLee [:catlee]]

Comment on attachment 641556 [details] [diff] [review]
v1

Review of attachment 641556 [details] [diff] [review]:
-----------------------------------------------------------------

does bin/ssltunnel exist on all branches/platforms?

Comment 8

[Honza Bambas (:mayhemer)]

(In reply to Chris AtLee [:catlee] from comment #7)
> Comment on attachment 641556 [details] [diff] [review]
> v1
> 
> Review of attachment 641556 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> does bin/ssltunnel exist on all branches/platforms?

It is always built and installed (using PROGRAM=ssltunnel in the related Makefile) when mochitest is enabled.  I believe enabling xpcshell tests is automatically implied with enabling mochitest.  I.e. --enalble-tests ensures there is ssltunnel.

I soon plan to move ssltunnel to a more general place, probably under <src-root>/testing/ssltunnel or so (no bug for it right now).

Does this answer your question?

Comment 9

[Honza Bambas (:mayhemer)]

And it is built on all branches right now and also on all platforms.

Comment 10

[Chris AtLee [:catlee]]

even mozilla-esr10?

Comment 11

[(not currently active) Ted Mielczarek]

ssltunnel has been used as part of Mochitest since the 1.9.1 branch.

Comment 12

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/build/buildbotcustom/rev/dc9a82c9e50d

Comment 13

[Honza Bambas (:mayhemer)]

What is the state of this patch deployment on the production machines?  I'd like to move forward with the depending bug.  Thanks.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

It was deployed to production yesterday. Seems to be working in 
https://tbpl.mozilla.org/php/getParsedLog.php?id=14101948&tree=Mozilla-Inbound&full=1

Comment 15

[Honza Bambas (:mayhemer)]

(In reply to Nick Thomas [:nthomas] from comment #14)
> It was deployed to production yesterday. Seems to be working in 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=14101948&tree=Mozilla-
> Inbound&full=1

Awesome!  I was looking by coincidence to a log two days old :)

Thanks a lot.