The default bug view has changed. See this FAQ.

some return values in Windows runtime stub are wrong type or wrongly interpreted

RESOLVED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

14 Branch
Firefox 16
All
Windows 7
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 632380 [details] [diff] [review]
patch v1: corrects return values

While reviewing the fix for bug 760747, I noticed that in the Windows webapp runtime stub AttemptGRELoadAndLaunch() sometimes returns an nsresult (i.e. an int), although its return type is boolean.  And main() assigns the return value of GetFirefoxDirFromRegistry() to `rv`, which is an nsresult, although the return value of that function is a boolean.

Here are the obvious fixes.
Attachment #632380 - Flags: review?(felipc)
Attachment #632380 - Flags: review?(felipc) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 632380 [details] [diff] [review]
patch v1: corrects return values

https://hg.mozilla.org/integration/mozilla-inbound/rev/deaaaefbc089
Attachment #632380 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/deaaaefbc089
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Sounds like this is internal code changes - no verification needed (correct me if I'm incorrect though Myk if you think there is end-user testing to this).
Whiteboard: [qa-]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.