Last Comment Bug 764127 - some return values in Windows runtime stub are wrong type or wrongly interpreted
: some return values in Windows runtime stub are wrong type or wrongly interpreted
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: 14 Branch
: All Windows 7
: -- normal
: Firefox 16
Assigned To: Myk Melez [:myk] [@mykmelez]
: Jason Smith [:jsmith]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-12 13:18 PDT by Myk Melez [:myk] [@mykmelez]
Modified: 2016-03-21 12:39 PDT (History)
4 users (show)
jsmith: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1: corrects return values (1.16 KB, patch)
2012-06-12 13:18 PDT, Myk Melez [:myk] [@mykmelez]
felipc: review+
myk: checkin+
Details | Diff | Splinter Review

Description Myk Melez [:myk] [@mykmelez] 2012-06-12 13:18:45 PDT
Created attachment 632380 [details] [diff] [review]
patch v1: corrects return values

While reviewing the fix for bug 760747, I noticed that in the Windows webapp runtime stub AttemptGRELoadAndLaunch() sometimes returns an nsresult (i.e. an int), although its return type is boolean.  And main() assigns the return value of GetFirefoxDirFromRegistry() to `rv`, which is an nsresult, although the return value of that function is a boolean.

Here are the obvious fixes.
Comment 1 Myk Melez [:myk] [@mykmelez] 2012-06-12 13:36:12 PDT
Comment on attachment 632380 [details] [diff] [review]
patch v1: corrects return values

https://hg.mozilla.org/integration/mozilla-inbound/rev/deaaaefbc089
Comment 2 Ed Morley [:emorley] 2012-06-13 05:59:54 PDT
https://hg.mozilla.org/mozilla-central/rev/deaaaefbc089
Comment 3 Jason Smith [:jsmith] 2012-06-13 09:00:02 PDT
Sounds like this is internal code changes - no verification needed (correct me if I'm incorrect though Myk if you think there is end-user testing to this).

Note You need to log in before you can comment on or make changes to this bug.