764219 - HTTP: from Affiliates code snippets

Status: VERIFIED INVALID

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect, P1)

Description

[Chris More [:cmore]]

The http: is missing from the fully qualified domain name for banner links and images. 

See below:

<a href="//affiliates.mozilla.org/link/banner/18990"><img src="//affiliates.mozilla.org/media/uploads/banners/a923c2ca8aaa6e720053fcc0ac4a51f520d0cabc.png" alt="Android" /></a>

This is for both new and existing banners when viewing:

https://affiliates.mozilla.org/en-US/my_banners

This would prevent anyone from putting a banner on a website and having that translate to a download. This is something automated testing could catch.

Comment 1

[Matt Brandt [:mbrandt]]

Along with the fix let's also breakout what tests we should have and where they live. Are there developer level unit tests that can catch this or should they live in webqa's CI?

Comment 2

[Chris More [:cmore]]

Not a problem! I had a brief moment of clarity after Ben mentioned that it could be on purpose. Then I remember we removed the http so that people don't get certificate issues with hosting an http image on an https website. Resolved, invalid!

Comment 3

[Matt Brandt [:mbrandt]]

Easy enough - thanks cmore - bumping to verified invalid, dishes are done http://www.youtube.com/watch?v=CMiEpeKMNQI

Comment 4

[Chris More [:cmore]]

Just to clarify, <img src="//affiliates.mozilla.org/media/uploads/banners/a923c2ca8aaa6e720053fcc0ac4a51f520d0cabc.png" alt="Android" /> is valid HTML4 and HTML5.

The Missing http: just means that it will inherit the protocol from the source website. For example, if you put a banner on https://www.example.com, the affiliates banner links will be set to https: per the browser. If you put the code on http://www.example.com, the links would be to the http: protocol. This was done on purpose since the Affiliates site can't control if the source website hosting the banner will be HTTP or HTTPs protocol.