Closed
Bug 764248
Opened 12 years ago
Closed 12 years ago
Rework BrowserElementParent.js so that each frame element gets its own BrowserElementParent object
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
18.48 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Right now, we have only one BrowserElementParent object per process. Because the one BrowserElementParent serves multiple frame elements, we pass around a frameElement parameter everywhere. It is ungood.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
Assignee | ||
Updated•12 years ago
|
Attachment #632797 -
Flags: review? → review?(21)
Assignee | ||
Comment 2•12 years ago
|
||
Dale, this will probably rot your patches. Sorry to keep doing this to you.
Comment 3•12 years ago
|
||
Comment on attachment 632797 [details] [diff] [review] Patch v1 Review of attachment 632797 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good. Sorry for having taken so long to review. ::: dom/browser-element/BrowserElementParent.js @@ +24,2 @@ > * > + * BrowserElementParentFactory detects when we create a a windows or docshell nit: a a windows -> a window or a docshell @@ +164,5 @@ > + defineMethod('getCanGoBack', this._getCanGoBack); > + defineMethod('getCanGoForward', this._getCanGoForward); > + > + self._mm.loadFrameScript("chrome://global/content/BrowserElementChild.js", > + /* allowDelayedLoad = */ true); nit: self -> this. it seems also that there is an small indent issue
Attachment #632797 -
Flags: review?(21) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3791f6709c
Assignee | ||
Comment 5•12 years ago
|
||
Ah, crap, I missed the self -> this change. Sorry! I'll fix it next time I touch this file.
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd3791f6709c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•