764266 - Remove WINCE support on c-c

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Makoto Kato [:m_kato]]

m-c remove WinCE support.  We should remove it on c-c.

Also, this fix removes unused codes.  (CYGWIN, ActiveState perl support and etc)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 632546 [details] [diff] [review]
fix

Review of attachment 632546 [details] [diff] [review]:
-----------------------------------------------------------------

I won't get to this anytime real soon, if serge is around and wants to give it a glance, I'll (a) thank him by attacking his reviews sooner, and (b) be able to sign off on this one faster.

Standard8 can review in lieu of all of the rest of us though.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 632546 [details] [diff] [review]
fix

Sorry, I was told long ago not to maintain c-c "configure" anymore.
As this bug seems (good) cleanup only, I differ to Mark.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> As this bug seems (good) cleanup only, I differ to Mark.

s/differ/defer/

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix v2

Sorry for the delay in reviewing this. I had to update it for a bit of bitrot, and this is the patch.

Whilst we're not generally porting patches at the moment, as we're looking at reworking the build system, I think we can take this as it is here.

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/comm-central/rev/efe3697a5648

Comment 7

[[e-mail]]

Comment on attachment 652793 [details] [diff] [review]
The fix v2

>@@ -2135,21 +1954,14 @@
>     no_x=yes
>     AC_DEFINE(NO_X11)
> 
>-    dnl MinGW/MSYS doesn't provide or need cygpath
>     case "$host" in
>     *-mingw*)
>-	CYGPATH_W=echo
>-	CYGPATH_S=cat
> 	MOZ_BUILD_ROOT=`cd $MOZ_BUILD_ROOT && pwd -W`
> 	;;
>-    *-cygwin*|*-msvc*|*-mks*)
>-	CYGPATH_W="cygpath -a -w"
>-	CYGPATH_S="sed -e s|\\\\|/|g"
>-	MOZ_BUILD_ROOT=`$CYGPATH_W $MOZ_BUILD_ROOT | $CYGPATH_S`
>-	;;
>     esac
>+
>     case "$host" in
>-    *-mingw*|*-cygwin*|*-msvc*|*-mks*)
>+    *-mingw*)
> 
>     if test -z "$MOZ_TOOLS"; then
>         AC_MSG_ERROR([MOZ_TOOLS is not set])
[These used to be separate cases because cygwin didn't use pwd -W, but having dropped support for cygwin, you could have merged these two cases into one.]