Closed Bug 764266 Opened 8 years ago Closed 7 years ago

Remove WINCE support on c-c

Categories

(MailNews Core :: Build Config, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 18.0

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

m-c remove WinCE support.  We should remove it on c-c.

Also, this fix removes unused codes.  (CYGWIN, ActiveState perl support and etc)
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → m_kato
Attachment #632546 - Flags: review?(bugspam.Callek)
Comment on attachment 632546 [details] [diff] [review]
fix

Review of attachment 632546 [details] [diff] [review]:
-----------------------------------------------------------------

I won't get to this anytime real soon, if serge is around and wants to give it a glance, I'll (a) thank him by attacking his reviews sooner, and (b) be able to sign off on this one faster.

Standard8 can review in lieu of all of the rest of us though.
Attachment #632546 - Flags: review?(sgautherie.bz)
Attachment #632546 - Flags: review?(mbanner)
Blocks: 614720
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment on attachment 632546 [details] [diff] [review]
fix

Sorry, I was told long ago not to maintain c-c "configure" anymore.
As this bug seems (good) cleanup only, I differ to Mark.
Attachment #632546 - Flags: review?(sgautherie.bz)
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> As this bug seems (good) cleanup only, I differ to Mark.

s/differ/defer/
Attached patch The fix v2Splinter Review
Sorry for the delay in reviewing this. I had to update it for a bit of bitrot, and this is the patch.

Whilst we're not generally porting patches at the moment, as we're looking at reworking the build system, I think we can take this as it is here.
Attachment #632546 - Attachment is obsolete: true
Attachment #632546 - Flags: review?(mbanner)
Attachment #632546 - Flags: review?(bugspam.Callek)
Attachment #652793 - Flags: review+
https://hg.mozilla.org/comm-central/rev/efe3697a5648
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 652793 [details] [diff] [review]
The fix v2

>@@ -2135,21 +1954,14 @@
>     no_x=yes
>     AC_DEFINE(NO_X11)
> 
>-    dnl MinGW/MSYS doesn't provide or need cygpath
>     case "$host" in
>     *-mingw*)
>-	CYGPATH_W=echo
>-	CYGPATH_S=cat
> 	MOZ_BUILD_ROOT=`cd $MOZ_BUILD_ROOT && pwd -W`
> 	;;
>-    *-cygwin*|*-msvc*|*-mks*)
>-	CYGPATH_W="cygpath -a -w"
>-	CYGPATH_S="sed -e s|\\\\|/|g"
>-	MOZ_BUILD_ROOT=`$CYGPATH_W $MOZ_BUILD_ROOT | $CYGPATH_S`
>-	;;
>     esac
>+
>     case "$host" in
>-    *-mingw*|*-cygwin*|*-msvc*|*-mks*)
>+    *-mingw*)
> 
>     if test -z "$MOZ_TOOLS"; then
>         AC_MSG_ERROR([MOZ_TOOLS is not set])
[These used to be separate cases because cygwin didn't use pwd -W, but having dropped support for cygwin, you could have merged these two cases into one.]
You need to log in before you can comment on or make changes to this bug.