Use virtual keycodes in SDK for Mac instead of defined by ourselves

RESOLVED FIXED in mozilla16

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla16
x86_64
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
Created attachment 632591 [details] [diff] [review]
part.1 Use virtual keycodes defined in SDK

It doesn't make sense to redefine keycode by our naming rules.
Attachment #632591 - Flags: review?(smichaud)
Created attachment 632592 [details] [diff] [review]
part.2 Use naming rules of virtual keycodes in SDK for defining undefined keycode

Use same naming rules when we define undefined keycodes.
Attachment #632592 - Flags: review?(smichaud)
Blocks: 768736
Comment on attachment 632591 [details] [diff] [review]
part.1 Use virtual keycodes defined in SDK

Where do symbols like "kVK_F16" live?  I can't find them anywhere in the tree.

What is the "SDK"?  It seems to be a separate download.  Which means that these patches will make it an additional build prerequisite.
> Where do symbols like "kVK_F16" live?  I can't find them anywhere in the tree.

Never mind.  I just found them in the Events.h header file of Apple's HIToolbox framework.
Comment on attachment 632591 [details] [diff] [review]
part.1 Use virtual keycodes defined in SDK

This looks fine to me.

I notice that you've dropped the "tilde" keycode (0x32).  But that's just because Events.h calls it by a different name (kVK_ANSI_Grave).

I did a build (on OS X 10.7.4) of both this bug's patches, and it finished with no problems.
Attachment #632591 - Flags: review?(smichaud) → review+
Comment on attachment 632592 [details] [diff] [review]
part.2 Use naming rules of virtual keycodes in SDK for defining undefined keycode

Looks fine to me.

I did a build (on OS X 10.7.4) of both this bug's patches, and it finished with no problems.
Attachment #632592 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f516031218f
https://hg.mozilla.org/integration/mozilla-inbound/rev/83f49d543833
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/83f49d543833
https://hg.mozilla.org/mozilla-central/rev/0f516031218f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.