764303 - Search suggestions not working

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

Steps to reproduce:
1) Focus the search box.
2) Begin typing a search term.
3) Search suggestions do not appear.

NOTE: Reproducible in production and -dev.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Looks like it regressed with this commit: https://github.com/mozilla/zamboni/commit/dd83a8c9

Comment 2

[Davor Spasovski [:spasovski]]

I am sure I tested this extensively but it's possible something was missed.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

It looks like you added the suggestions.js back to the Marketplace consumer JS bundle (https://github.com/cvan/zamboni/commit/50a7217) but I still see a few outstanding issues:

1) Icons are not being displayed (http://cl.ly/2s3J1w3h2o0R3l3U111o) since it looks like the icon field was accidentally removed from the JSON (http://cl.ly/1X3F1Y2E0u1X321G0K38)
2) https://marketplace-dev.allizom.org/en-US/search/suggestions?q=basecam is tracebacking: http://cl.ly/3j3B3g0h162m3Q2h1J05

Comment 4

[Davor Spasovski [:spasovski]]

Wow none of that should've been broken by the JS refactoring work. Good catch tho I'll look into it.

Comment 5

[Davor Spasovski [:spasovski]]

Will open a new bug for the traceback, the rest should be OK:

https://github.com/mozilla/zamboni/commit/e2e4800

Comment 6

[Cristian Boldan]

Issue is still reproducing in MP-dev https://marketplace-dev.allizom.org/
Screencast for this issue http://screencast.com/t/k5CLFSnScNX

Comment 7

[Christopher Van Wiemeersch [:cvan]]

(In reply to Cristian Boldan from comment #6)
> Issue is still reproducing in MP-dev https://marketplace-dev.allizom.org/
> Screencast for this issue http://screencast.com/t/k5CLFSnScNX

This is definitely a different bug. Please open a new one.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

This looks like the issue you were talking about on Android - right, Basta and Davor?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Krupa's filing a new bug.

Comment 10

[Victor Carciu]

The original bug described by cvan is reproducible again on desktop,for both staging and production.

Comment 11

[Florin Strugariu [:Bebe]]

here is the test video from automation:

https://saucelabs.com/jobs/f59bf0f5854a4cfcbe17e41f16dfc83c#

Comment 12

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/cb7e70a

Comment 13

[Victor Carciu]

Issue still reproducible on latest FF Nightly.

Comment 14

[Matt Basta [:basta]]

This bug has changed quite a bit over its lifespan.

Victor: Is the issue still the same as the one demonstrated in comment #11, or is it a different kind of broken?

I'm also curious as to whether the WD failure may be a separate issue. I.e.: perhaps WebDriver fires off a different event/change than the one we're listening for to trigger search suggestions. It's not inconceivable that the way we're polling for updates isn't automation-friendly.

Comment 15

[Davor Spasovski [:spasovski]]

we pushed a new fix: https://github.com/mozilla/zamboni/commit/30d7b65

Comment 16

[Victor Carciu]

Verified as fixed

Comment 17

[Victor Carciu]

Attachment: Postfix screenshot