Last Comment Bug 764333 - Link from error console to view source doesn't work for errors in subscripts
: Link from error console to view source doesn't work for errors in subscripts
Status: RESOLVED FIXED
:
Product: Toolkit Graveyard
Classification: Graveyard
Component: Error Console (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla16
Assigned To: Geoff Lankow (:darktrojan)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-13 04:37 PDT by Geoff Lankow (:darktrojan)
Modified: 2016-06-29 11:02 PDT (History)
2 users (show)
geoff: in‑testsuite-
geoff: in‑litmus-
geoff: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix (791 bytes, patch)
2012-06-13 04:37 PDT, Geoff Lankow (:darktrojan)
blair: review+
Details | Diff | Splinter Review

Description User image Geoff Lankow (:darktrojan) 2012-06-13 04:37:20 PDT
Created attachment 632638 [details] [diff] [review]
fix

If the error occurs in a subscript, the console displays |resource://foo/bar -> resource://foo/baz| as the link, and if you click on it, tries to go to |view-source:resource://foo/bar -> resource://foo/baz|.
Comment 1 User image Geoff Lankow (:darktrojan) 2012-06-13 04:48:49 PDT
Bug 418356 comment 9 for some light background reading.
Comment 2 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-06-13 05:15:26 PDT
Comment on attachment 632638 [details] [diff] [review]
fix

Review of attachment 632638 [details] [diff] [review]:
-----------------------------------------------------------------

If URLs with spaces in them are escaped, I can't think of any other reason there would be a space that we wouldn't want to split on - so I guess that works.
Comment 3 User image Geoff Lankow (:darktrojan) 2012-06-14 02:22:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8238919579
Comment 4 User image Ed Morley [:emorley] 2012-06-15 06:00:46 PDT
https://hg.mozilla.org/mozilla-central/rev/3c8238919579

Note You need to log in before you can comment on or make changes to this bug.