Using build 2001041704 on Win2K Steps to Reproduce: 1. Open the prefs dialog 2. Go to Navigator->Languages 3. Push the Add... button Results: The correct dialog opens, but with this error: Error: document.getElementById("remove") has no properties Source File: chrome://communicator/content/pref/pref-languages.js Line: 593 This error does not prevent the language from being added.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 77681 has been marked as a duplicate of this bug. ***
*** Bug 82876 has been marked as a duplicate of this bug. ***
I don't see this warning to stdout, linux or w2k. -> WFM
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WORKSFORME
oops you're right, I was looking at stdout, yes I see this in JS console. reopening
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee: mcafee → matt
Status: REOPENED → NEW
*** Bug 77047 has been marked as a duplicate of this bug. ***
*** Bug 84118 has been marked as a duplicate of this bug. ***
matt: I'm taking this, could be a problem in my code in language prefs...
Assignee: matt → jbetak
Created attachment 42142 [details] [diff] [review] trunk patch - SelectLanguage() should only be called by the main pref panel
matt: could you please review this? SelectLanguage() was called by the popup window, which caused this JS error. I also revised the opendialog parameters to address some nasty flickering... Thanks!
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Target Milestone: --- → mozilla0.9.3
Whiteboard: have fix, need r/sr
adding jag for r, since he has worked with pref-languages.js, cc'ing blake and ben for possible sr.
pushing out to 0.9.4
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Whiteboard: have fix, need r/sr → have fix, need sr
cc'ing shaver for JS sr...
Chris: could you sr this one as well? It's a one-liner...
patch checked in - thanks everyone!
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago → 18 years ago
Resolution: --- → FIXED
vrfy fixed; no longer see the js error when clicking the Add button. linux, 2001.08.22.08-comm winnt, 2001.08.22.09-comm mac 9.1, 2001.08.22.08-comm
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.