Last Comment Bug 764469 - Make c-c build system compatible with OS X 10.8
: Make c-c build system compatible with OS X 10.8
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Mac OS X
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Nomis101
:
Mentors:
Depends on:
Blocks: TB-mountain-lion-com
  Show dependency treegraph
 
Reported: 2012-06-13 10:20 PDT by Nomis101
Modified: 2012-06-20 14:31 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
WIP (938 bytes, patch)
2012-06-13 10:20 PDT, Nomis101
no flags Details | Diff | Splinter Review
Fix build issues on 10.8 (7.20 KB, patch)
2012-06-14 10:14 PDT, Nomis101
standard8: review+
Details | Diff | Splinter Review

Description Nomis101 2012-06-13 10:20:30 PDT
Created attachment 632758 [details] [diff] [review]
WIP

This currently only ports Bug 750574. I will tweak the other stuff in the next few days.
Comment 1 Nomis101 2012-06-14 10:14:53 PDT
Created attachment 633174 [details] [diff] [review]
Fix build issues on 10.8

OK, this patch now fixes every issue in MailnewsCore I had while building TB on 10.8. First, because of the egrep issue, I had to port Bug 750574. The second problem is, that per default it trys to build with llvm-gcc, but this isn't supported from Mozilla and it fails with an error. So I also had to port the "select clang over llvm-gcc" patch from Bug 555727. Because Apple ships in 10.8 an enhanced version of Clang, I had to include MOZ_COMPILER_OPTS from Bug 727145. In Bug 762071 the position of this MOZ_COMPILER_OPTS has changed and the rtti part has moved to compiler-opts.m4, so I better also ported Bug 762071 (to be on the safe side).

With this patch now I can build TB on 10.8 DP4 until I run into Bug 747621 (which I try to fix there).
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-06-19 15:28:16 PDT
https://hg.mozilla.org/comm-central/rev/2b69382950af

Thanks for the patch! In the future, please follow the directions below for patches you submit. It makes life much easier for those checking them in on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 3 Nomis101 2012-06-20 14:31:05 PDT
(In reply to Ryan VanderMeulen from comment #2)
> https://hg.mozilla.org/comm-central/rev/2b69382950af
> 
> Thanks for the patch! In the future, please follow the directions below for
> patches you submit. It makes life much easier for those checking them in on
> your behalf. Thanks!
> https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Yes I know, sorry for that, 'hg qnew' doesn't work for me currently on 10.8. :-(
Thanks for checkin in.

Note You need to log in before you can comment on or make changes to this bug.