Make c-c build system compatible with OS X 10.8

RESOLVED FIXED in Thunderbird 16.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Nomis101, Assigned: Nomis101)

Tracking

Trunk
Thunderbird 16.0
All
Mac OS X
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.20 KB, patch
standard8
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 632758 [details] [diff] [review]
WIP

This currently only ports Bug 750574. I will tweak the other stuff in the next few days.
(Assignee)

Comment 1

5 years ago
Created attachment 633174 [details] [diff] [review]
Fix build issues on 10.8

OK, this patch now fixes every issue in MailnewsCore I had while building TB on 10.8. First, because of the egrep issue, I had to port Bug 750574. The second problem is, that per default it trys to build with llvm-gcc, but this isn't supported from Mozilla and it fails with an error. So I also had to port the "select clang over llvm-gcc" patch from Bug 555727. Because Apple ships in 10.8 an enhanced version of Clang, I had to include MOZ_COMPILER_OPTS from Bug 727145. In Bug 762071 the position of this MOZ_COMPILER_OPTS has changed and the rtti part has moved to compiler-opts.m4, so I better also ported Bug 762071 (to be on the safe side).

With this patch now I can build TB on 10.8 DP4 until I run into Bug 747621 (which I try to fix there).
Attachment #632758 - Attachment is obsolete: true
Attachment #633174 - Flags: review?(mbanner)
Attachment #633174 - Flags: review?(mbanner) → review+
Assignee: nobody → Nomis101
Hardware: x86 → All
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2b69382950af

Thanks for the patch! In the future, please follow the directions below for patches you submit. It makes life much easier for those checking them in on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
(Assignee)

Comment 3

5 years ago
(In reply to Ryan VanderMeulen from comment #2)
> https://hg.mozilla.org/comm-central/rev/2b69382950af
> 
> Thanks for the patch! In the future, please follow the directions below for
> patches you submit. It makes life much easier for those checking them in on
> your behalf. Thanks!
> https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Yes I know, sorry for that, 'hg qnew' doesn't work for me currently on 10.8. :-(
Thanks for checkin in.
You need to log in before you can comment on or make changes to this bug.