764512 - makefiles: source repo path -vs variant build defines

Status: NEW

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

Not sure how much of a problem this is but variant builds can occur based on how a mercurial sandbox was checked out.

Remote repository:
% hg clone http://hg.mozilla.org/mozilla-central mozilla-central
% cd mozilla-central
% hg showconfig paths.default
http://hg.mozilla.org/mozilla-central

Clone a local repository:
% hg clone mozilla-central local-repo
% cd local-repo
% hg showconfig paths.default
/local/mozilla/bugs/mozilla-central

Most makefiles will test the path before using it.  Some for a value, others for 'http':

# extra sanity check for old versions of hg, no showconfig support
ifeq (http,$(patsubst http%,http,$(SOURCE_REPO)))
  INIARGS += --sourcerepo=$(SOURCE_REPO)
endif


If checking 'http' is used to guarantee a remote repository URL in defines these conditionals are fine.  If the logic was used to validate values from an older hg version(s) the check should probably test for a non-NULL value to avoid variant code paths.


Also this logic should also be updated to function with different revision control systems: mercurial, git, etc.  People building within a sandbox checked out from a git repository will not have the same defines available (~SOURCE_REPO) as a person building within a mercurial sandbox.

Comment 1

[Joey Armstrong [:joey]]

When querying for a SOURCE_REPO

>> Most makefiles will test the path before using it.  Some for a value, others for 'http':

Comment 2

[Benjamin Smedberg]

I really don't think we should worry about this.