Comment out bug 693938's noisy NS_WARNING about transparent content

RESOLVED INACTIVE

Status

()

Core
Layout: Misc Code
P4
normal
RESOLVED INACTIVE
6 years ago
a day ago

People

(Reporter: cpeterson, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 693938 added an NS_WARNING about transparent content with displayports. Unfortunately, this warning can get VERY noisy when Fennec is taking screenshots of web pages.

blassey says, "that warning should probably be removed. it's not useful."


I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
(Reporter)

Comment 1

6 years ago
Created attachment 632814 [details] [diff] [review]
comment-out-warning.patch

Comment out bug 693938's noisy NS_WARNING about transparent content. blassey says, "that warning should probably be removed. it's not useful."
Assignee: nobody → cpeterson
Attachment #632814 - Flags: review?(roc)
(Reporter)

Updated

6 years ago
Status: NEW → ASSIGNED
I actually think this warning could be important. Why are we hitting it?
(Reporter)

Comment 3

6 years ago
blassey, in bug 693938, romaxa marked XUL Fennec's checkerboard layer as RGB24 and CONTENT_OPAQUE. Native Fennec's CheckerboardImage.java is a RGB565 CairoImage, but we don't seem to specify that the checkerboard is opaque. Is that set elsewhere or not applicable to Native Fennec?
(Reporter)

Comment 4

6 years ago
Cwiiis, does this layout warning about our root layer not being opaque look like something we should fix? I see this warning all the time when Fennec is saving screenshots:

I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639

Comment 5

6 years ago
(In reply to Chris Peterson (:cpeterson) from comment #4)
> Cwiiis, does this layout warning about our root layer not being opaque look
> like something we should fix? I see this warning all the time when Fennec is
> saving screenshots:
> 
> I/Gecko ( 8965): WARNING: We don't support transparent content with
> displayports, force it to be opqaue: file
> /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639

I recall we fixed something along these lines, perhaps bug 733607? Is this just an issue with taking of screenshots? It wouldn't hurt to fix it, certainly - Cc'ing kats in case his memory is fresher than mine.
I don't recall anything about this, sorry :( I don't think I was involved in bug 733607 either.
(Reporter)

Comment 7

6 years ago
(In reply to Chris Lord [:cwiiis] from comment #5)
> I recall we fixed something along these lines, perhaps bug 733607? Is this
> just an issue with taking of screenshots? It wouldn't hurt to fix it,

I don't know if this issue only affects screenshots, but it is triggered every time we take a screenshot.
(Just as an aside, if you do land this patch, please fix the typo: s/opqaue/opaque/. It's driving me nuts now!)
(Reporter)

Comment 9

6 years ago
kats, my patch already includes the spelling fix. :)
Status: ASSIGNED → NEW
(Reporter)

Updated

6 years ago
Priority: -- → P4
(Reporter)

Comment 10

6 years ago
Comment on attachment 632814 [details] [diff] [review]
comment-out-warning.patch

Withdrawing r=? until roc's question can be properly answered.
Attachment #632814 - Flags: review?(roc)
(Reporter)

Updated

6 years ago
Assignee: cpeterson → nobody

Comment 11

a day ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: a day ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.