764524 - Comment out bug 693938's noisy NS_WARNING about transparent content

Status: NEW

(Core :: Layout, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Bug 693938 added an NS_WARNING about transparent content with displayports. Unfortunately, this warning can get VERY noisy when Fennec is taking screenshots of web pages.

blassey says, "that warning should probably be removed. it's not useful."


I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639
I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: comment-out-warning.patch

Comment out bug 693938's noisy NS_WARNING about transparent content. blassey says, "that warning should probably be removed. it's not useful."

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I actually think this warning could be important. Why are we hitting it?

Comment 3

[Chris Peterson [:cpeterson]]

blassey, in bug 693938, romaxa marked XUL Fennec's checkerboard layer as RGB24 and CONTENT_OPAQUE. Native Fennec's CheckerboardImage.java is a RGB565 CairoImage, but we don't seem to specify that the checkerboard is opaque. Is that set elsewhere or not applicable to Native Fennec?

Comment 4

[Chris Peterson [:cpeterson]]

Cwiiis, does this layout warning about our root layer not being opaque look like something we should fix? I see this warning all the time when Fennec is saving screenshots:

I/Gecko ( 8965): WARNING: We don't support transparent content with displayports, force it to be opqaue: file /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Chris Peterson (:cpeterson) from comment #4)
> Cwiiis, does this layout warning about our root layer not being opaque look
> like something we should fix? I see this warning all the time when Fennec is
> saving screenshots:
> 
> I/Gecko ( 8965): WARNING: We don't support transparent content with
> displayports, force it to be opqaue: file
> /Users/cpeterson/Code/mozilla/central/layout/base/nsDisplayList.cpp, line 639

I recall we fixed something along these lines, perhaps bug 733607? Is this just an issue with taking of screenshots? It wouldn't hurt to fix it, certainly - Cc'ing kats in case his memory is fresher than mine.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I don't recall anything about this, sorry :( I don't think I was involved in bug 733607 either.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Chris Lord [:cwiiis] from comment #5)
> I recall we fixed something along these lines, perhaps bug 733607? Is this
> just an issue with taking of screenshots? It wouldn't hurt to fix it,

I don't know if this issue only affects screenshots, but it is triggered every time we take a screenshot.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

(Just as an aside, if you do land this patch, please fix the typo: s/opqaue/opaque/. It's driving me nuts now!)

Comment 9

[Chris Peterson [:cpeterson]]

kats, my patch already includes the spelling fix. :)

Comment 10

[Chris Peterson [:cpeterson]]

Comment on attachment 632814 [details] [diff] [review]
comment-out-warning.patch

Withdrawing r=? until roc's question can be properly answered.

Comment 11

[Johnny Onemusic]

Attachment: same problem

Thanks from enapciowin1987.