764605 - The use of the footer-element in forms is not correct

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0a1
Build ID: 20120609030536

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://addons.mozilla.org/en-US/firefox/users/login?to=%2Fen-US%2Ffirefox%2F in the address bar and press Enter
2. Inspect the button#login-submit


Actual results:

The button is located inside of a <footer> element.


Expected results:

The footer element should be removed because as the spec says: 

"The footer element represents a footer for its nearest ancestor sectioning content or sectioning root element. A footer typically contains information about its section such as who wrote it, links to related documents, copyright data, and the like."
http://dev.w3.org/html5/spec/the-footer-element.html#the-footer-element

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/pull/1728

Kevin or Chris: It looks like this PR was updated since you looked last. Could you take another look?

Comment 2

[David Larlet [:davidbgk]]

Merged in Zamboni: https://github.com/mozilla/zamboni/commit/bb4a642a75da95bce4a4165bb0dd22f1ba15ad16
PR in Olympia: https://github.com/mozilla/olympia/pull/43

Comment 3

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/e3cfa4c8c811e0d2173cbd63a012e0d834fc3856

Comment 4

[krupa raj[:krupa]]

verified fixed on addons-dev.

Comment 5

[krupa raj[:krupa]]

Attachment: post-fix screenshot