764622 - BrowserApp calls invalidateOptionsMenu() redundantly

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

During TabEvent START and STOP, BrowserApp calls invalidateOptionsMenu(), which is anyway called in GeckoApp.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This removes the redundant part.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 632915 [details] [diff] [review]
Patch

Review of attachment 632915 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops. Good catch. Thanks!

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9bf21ba748d4

Comment 4

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out because something in the push caused various failures in mochitest-1, 2, 3, and 8.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c820098cb62d

Comment 5

[Michael Kohler [:mkohler]]

(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> Sorry, I backed this out because something in the push caused various
> failures in mochitest-1, 2, 3, and 8.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c820098cb62d

Can we push that again?

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.