Closed Bug 764622 Opened 9 years ago Closed 1 month ago

BrowserApp calls invalidateOptionsMenu() redundantly

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: sriram, Unassigned)

Details

Attachments

(1 file)

During TabEvent START and STOP, BrowserApp calls invalidateOptionsMenu(), which is anyway called in GeckoApp.
Attached patch PatchSplinter Review
This removes the redundant part.
Attachment #632915 - Flags: review?(wjohnston)
Comment on attachment 632915 [details] [diff] [review]
Patch

Review of attachment 632915 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops. Good catch. Thanks!
Attachment #632915 - Flags: review?(wjohnston) → review+
Sorry, I backed this out because something in the push caused various failures in mochitest-1, 2, 3, and 8.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c820098cb62d
(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> Sorry, I backed this out because something in the push caused various
> failures in mochitest-1, 2, 3, and 8.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c820098cb62d

Can we push that again?
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.