764649 - libSSL cleanup to make code inspection and reasoning easier

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

The attached patch makes two changes:

1. Declare ssl_DupSocket as static because it is only used in sslsock.c.

2. Always use PORT_ZNew to create sslSessionID objects.  This makes it
easier to search for the places where we create sslSessionID objects.

Comment 1

[Wan-Teh Chang]

Here is the definition of the PORT_ZNew macro:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/util/secport.h&rev=1.28&mark=101#101

Comment 2

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.14).

Checking in sslimpl.h;
/cvsroot/mozilla/security/nss/lib/ssl/sslimpl.h,v  <--  sslimpl.h
new revision: 1.106; previous revision: 1.105
done
Checking in sslsock.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v  <--  sslsock.c
new revision: 1.93; previous revision: 1.92
done
Checking in sslcon.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslcon.c,v  <--  sslcon.c
new revision: 1.51; previous revision: 1.50
done
Checking in sslsnce.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslsnce.c,v  <--  sslsnce.c
new revision: 1.63; previous revision: 1.62
done