Last Comment Bug 764774 - Remove unused instance of the old parser from nsParserUtils
: Remove unused instance of the old parser from nsParserUtils
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-14 04:54 PDT by Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01)
Modified: 2012-06-16 06:52 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Zap the unused variable (1.15 KB, patch)
2012-06-14 05:08 PDT, Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01)
bugs: review+
Details | Diff | Splinter Review
Real fix this time (4.62 KB, patch)
2012-06-15 00:56 PDT, Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01)
bugs: review+
Details | Diff | Splinter Review

Description Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-14 04:54:36 PDT
It appears that there is an unused instance of the old parser in nsParserUtils. Let's get rid of it.
http://mxr.mozilla.org/mozilla-central/source/parser/html/nsParserUtils.cpp#141
Comment 1 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-14 05:08:00 PDT
Created attachment 633104 [details] [diff] [review]
Zap the unused variable
Comment 2 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-14 05:20:51 PDT
Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d93e6ed8a49
Comment 3 Ed Morley [:emorley] 2012-06-14 06:36:52 PDT
Unfortunately had to back out for mochitest-chrome failures in test_bug675492.xul:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4d93e6ed8a49

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=12659367&tree=Mozilla-Inbound
{
13303 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/feeds/test/test_bug675492.xul | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIParserUtils.parseFragment] at chrome://mochitests/content/chrome/toolkit/components/feeds/test/test_bug675492.xul:26
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc082ae74492
Comment 4 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-15 00:56:00 PDT
Created attachment 633426 [details] [diff] [review]
Real fix this time

(In reply to Ed Morley [:edmorley] from comment #3)
> Unfortunately had to back out for mochitest-chrome failures in
> test_bug675492.xul:

Thanks. Sorry about landing without a try run. It appears that even the simplest-looking patches need one. :-(
Comment 5 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-15 03:51:14 PDT
Comment on attachment 633426 [details] [diff] [review]
Real fix this time

Try is green.
Comment 6 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2012-06-15 05:30:17 PDT
Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a61e819c1855
Comment 7 Ed Morley [:emorley] 2012-06-15 05:49:02 PDT
Bugs are left open until they merge to mozilla-central.
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-06-16 06:52:52 PDT
https://hg.mozilla.org/mozilla-central/rev/a61e819c1855

Note You need to log in before you can comment on or make changes to this bug.