Remove unused instance of the old parser from nsParserUtils

RESOLVED FIXED in mozilla16

Status

()

Core
HTML: Parser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
It appears that there is an unused instance of the old parser in nsParserUtils. Let's get rid of it.
http://mxr.mozilla.org/mozilla-central/source/parser/html/nsParserUtils.cpp#141
(Assignee)

Comment 1

5 years ago
Created attachment 633104 [details] [diff] [review]
Zap the unused variable
Attachment #633104 - Flags: review?(bugs)

Updated

5 years ago
Attachment #633104 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

5 years ago
Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d93e6ed8a49
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 3

5 years ago
Unfortunately had to back out for mochitest-chrome failures in test_bug675492.xul:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4d93e6ed8a49

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=12659367&tree=Mozilla-Inbound
{
13303 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/feeds/test/test_bug675492.xul | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIParserUtils.parseFragment] at chrome://mochitests/content/chrome/toolkit/components/feeds/test/test_bug675492.xul:26
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc082ae74492
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

5 years ago
Created attachment 633426 [details] [diff] [review]
Real fix this time

(In reply to Ed Morley [:edmorley] from comment #3)
> Unfortunately had to back out for mochitest-chrome failures in
> test_bug675492.xul:

Thanks. Sorry about landing without a try run. It appears that even the simplest-looking patches need one. :-(
Attachment #633104 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Comment on attachment 633426 [details] [diff] [review]
Real fix this time

Try is green.
Attachment #633426 - Flags: review?(bugs)

Updated

5 years ago
Attachment #633426 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

5 years ago
Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a61e819c1855
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
Bugs are left open until they merge to mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/a61e819c1855
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.