Avoid using gfxMatrix::SetMatrix in SVG code where possible.

RESOLVED FIXED in mozilla16

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 633128 [details] [diff] [review]
patch

We should avoid using gfxMatrix::SetMatrix in SVG code where possible.
Attachment #633128 - Flags: review?(bas.schouten)
(Assignee)

Comment 1

5 years ago
Created attachment 633129 [details] [diff] [review]
patch
Attachment #633128 - Attachment is obsolete: true
Attachment #633128 - Flags: review?(bas.schouten)
Attachment #633129 - Flags: review?(bas.schouten)
Comment on attachment 633129 [details] [diff] [review]
patch

Review of attachment 633129 [details] [diff] [review]:
-----------------------------------------------------------------

Should probably change the changeset message to say gfxContext::SetMatrix

::: layout/svg/base/src/nsSVGUtils.cpp
@@ +1404,5 @@
> +  gfxMatrix toRectSpace = aMatrix;
> +  toRectSpace.Invert();
> +  gfxPoint p = toRectSpace.Transform(gfxPoint(aX, aY));
> +  return rect.x <= p.x && p.x <= rect.XMost() &&
> +         rect.y <= p.y && p.y <= rect.YMost();

This is great! :)
Attachment #633129 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 3

5 years ago
> Should probably change the changeset message to say gfxContext::SetMatrix

Done, thanks. :)
(Assignee)

Comment 4

5 years ago
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/feff8604fde8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/feff8604fde8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.