Closed Bug 764813 Opened 8 years ago Closed 8 years ago

Avoid using gfxMatrix::SetMatrix in SVG code where possible.

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
We should avoid using gfxMatrix::SetMatrix in SVG code where possible.
Attachment #633128 - Flags: review?(bas.schouten)
Attached patch patchSplinter Review
Attachment #633128 - Attachment is obsolete: true
Attachment #633128 - Flags: review?(bas.schouten)
Attachment #633129 - Flags: review?(bas.schouten)
Comment on attachment 633129 [details] [diff] [review]
patch

Review of attachment 633129 [details] [diff] [review]:
-----------------------------------------------------------------

Should probably change the changeset message to say gfxContext::SetMatrix

::: layout/svg/base/src/nsSVGUtils.cpp
@@ +1404,5 @@
> +  gfxMatrix toRectSpace = aMatrix;
> +  toRectSpace.Invert();
> +  gfxPoint p = toRectSpace.Transform(gfxPoint(aX, aY));
> +  return rect.x <= p.x && p.x <= rect.XMost() &&
> +         rect.y <= p.y && p.y <= rect.YMost();

This is great! :)
Attachment #633129 - Flags: review?(bas.schouten) → review+
> Should probably change the changeset message to say gfxContext::SetMatrix

Done, thanks. :)
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/feff8604fde8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/feff8604fde8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.