764881 - hg bzexport should set assignee

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Steve Fink [:sfink] [:s:]]

Currently, it only takes bugs with |hg bzexport --new| and |hg newbug --take-bug|. It should also do it when using bzexport without --new.

Comment 1

[(not currently active) Ted Mielczarek]

Seems like a sensible default. Maybe just default --take-bug to on?

Comment 2

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #1)
> Seems like a sensible default. Maybe just default --take-bug to on?

Wait, the --no-take-bug option has a positive alternative that is not written in the help? I wish I had known earlier.

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Ted Mielczarek [:ted] from comment #1)
> Seems like a sensible default. Maybe just default --take-bug to on?

It already is for bzexport. (bzexport defaults to on, newbug defaults to off.) But the current implementation only ever sets the assignee if you're creating a bug. There's no code yet to set the assignee for an existing bug.

Comment 4

[(not currently active) Ted Mielczarek]

Aha! Yes, we should just make that work.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Take (set assignee of) existing bugs when attaching a patch, unless --no-take-bug is given

Unfortunately, this patch depends on bug 764881.

(And apologies to jdm if I sent you a review request for a landfill bug. Forget to switch back from testing mode when attaching this patch.)

Comment 6

[Steve Fink [:sfink] [:s:]]

And by 764881, I meant bug 778369.

Oh cool, looks like this patch made bzexport assign this bug properly. :-)

Comment 7

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/42e6ce540d2a

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: Take (set assignee of) existing bugs when attaching a patch, unless --no-take-bug is given.

Comment 9

[Nick Alexander :nalexander [he/him]]

Fascinating.  That's what happens when you run `hg bzexport' with no arguments as a test run :)

Comment 10

[Steve Fink [:sfink] [:s:]]

Heh. I would recommend using -i every time you use bzexport for a while, until you get used to it.

And even then, I still use -e for everything.

So really: start out always using -i -e. When comfortable, drop the -i.