Closed
Bug 764923
Opened 12 years ago
Closed 12 years ago
IonMonkey: Not inlining some functions due to OBJECT_FLAG_UNINLINEABLE
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.93 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
JM+TI sets this flag to signal that a function shouldn't be inlined. Ion also checks this flag, but in many cases Ion can inline these functions just fine. This prevents us from inlining some functions on Kraken imaging-darkroom - JM sets the flag there because it cannot generate native call stubs in inlined functions.
Assignee | ||
Comment 1•12 years ago
|
||
OBJECT_FLAG_UNINLINEABLE is set to either prevent us from expanding inlined frames over and over again or when JM wants to generate a native call/getter IC. With Ion we don't have to expand inline frames and we can generate ICs in inlined functions so I don't think we need to check this flag.
Attachment #633466 -
Flags: review?(bhackett1024)
Updated•12 years ago
|
Attachment #633466 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/a930dbb7ab60
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•