Don't use about:newtab for nsBrowserAccess

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 633199 [details] [diff] [review]
patch v1

nsBrowserAccess is (if I understood the code correctly) only used to open links with custom target attributes in a new window or new tab. We should continue to use about:blank as default here instead of about:newtab because that new docShell/window will be used to load a new link in it and there's no need to load about:newtab in there.

While working on bug 753448 I noticed the following assertion:

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindow.cpp#1471

This happens because we're opening a new tab and will be loading about:newtab and thus swapping a preloaded page. So it's actually more a timing issue that we didn't hit this assertion so far, I think.
Attachment #633199 - Flags: review?(gavin.sharp)
(Assignee)

Updated

5 years ago
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Comment on attachment 633199 [details] [diff] [review]
patch v1

Good catch; the only caller that passes null that I could find was nsContentTreeOwner::ProvideWindow, which indeed really specifically wants about:blank.
Attachment #633199 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

5 years ago
Thanks for the quick review!

https://hg.mozilla.org/integration/fx-team/rev/eaddef238d96
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eaddef238d96
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.