Last Comment Bug 764931 - Don't use about:newtab for nsBrowserAccess
: Don't use about:newtab for nsBrowserAccess
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
-- normal (vote)
: Firefox 16
Assigned To: Tim Taubert [:ttaubert]
: Dão Gottwald [:dao]
Depends on:
Blocks: 753448
  Show dependency treegraph
Reported: 2012-06-14 11:19 PDT by Tim Taubert [:ttaubert]
Modified: 2012-06-16 03:44 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1 (1.98 KB, patch)
2012-06-14 11:19 PDT, Tim Taubert [:ttaubert] review+
Details | Diff | Splinter Review

Description User image Tim Taubert [:ttaubert] 2012-06-14 11:19:00 PDT
Created attachment 633199 [details] [diff] [review]
patch v1

nsBrowserAccess is (if I understood the code correctly) only used to open links with custom target attributes in a new window or new tab. We should continue to use about:blank as default here instead of about:newtab because that new docShell/window will be used to load a new link in it and there's no need to load about:newtab in there.

While working on bug 753448 I noticed the following assertion:

This happens because we're opening a new tab and will be loading about:newtab and thus swapping a preloaded page. So it's actually more a timing issue that we didn't hit this assertion so far, I think.
Comment 1 User image :Gavin Sharp [email:] 2012-06-14 11:27:26 PDT
Comment on attachment 633199 [details] [diff] [review]
patch v1

Good catch; the only caller that passes null that I could find was nsContentTreeOwner::ProvideWindow, which indeed really specifically wants about:blank.
Comment 2 User image Tim Taubert [:ttaubert] 2012-06-14 11:31:28 PDT
Thanks for the quick review!
Comment 3 User image Tim Taubert [:ttaubert] 2012-06-16 03:44:54 PDT

Note You need to log in before you can comment on or make changes to this bug.