764952 - Deleting a review doesn't remove the associated rating

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Pick an app which has no rating
2. Add a review with a rating
3. Delete the review

expected behavior:
The review and its associated rating are deleted.
 
observed behavior:
The review gets deleted but the rating persists. Seehttps://marketplace-dev.allizom.org/en-US/app/campfire-7/reviews/

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Also see bug 625708.

Comment 2

[Matt Basta [:basta]]

This isn't possible with our current caching architecture. We have no way to invalidate queries which are an aggregate of a particular partition of a table. See https://github.com/jbalogh/django-cache-machine/issues/6

The consensus seems to be using Redis to handle this case, but we don't use Redis anymore, so it isn't going to help.

cvan said to keep this bug open because Krupa likes to collect caching bugs, so I'll leave it open.

Comment 3

[Matt Basta [:basta]]

Should be fixed, maybe:

https://github.com/mattbasta/zamboni/commit/7b2d3e810d505076021975f7e81f950827c304a1

Comment 4

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF19 (Win 7)
Postfix screencast http://screencast.com/t/sEsXxaa9N0s8
Closing bug.