764976 - Deleting calendar throws Error: error purging calendar: TypeError: calendar.deleteCalendar is not a function

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Stefan Sitter [:ssitter]]

Deleting a local storage calendar throws the following console message:

Error: error purging calendar: TypeError: calendar.deleteCalendar is not a function
Source File: [...]/calendar-js/calCalendarManager.js
Line: 748

Lightning 1.7a2 + Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120614 Thunderbird/15.0a2 (BuildID 20120614042001)

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Is the calendar deleted anyway? Looks like the platform is being more strict when QI is missing or classinfo is not set. Possibly similar cause to the canNotify bug.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: explicitly call QueryInterface()

It seem the problem can be fixed by explicitly calling QueryInterface().

Do you have any idea why this is required and not done implicitly? Is this an error in the storage provider? If I compare to caldav provider I see differences in getInterfaces() and QueryInterface(). For example it seems that calICalendar is implemented but not listed in any of the two methods.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: propossed fix for storage provider

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 633894 [details] [diff] [review]
propossed fix for storage provider

XPCOM is made to only offer a certain interface (i.e if called with ...createInstance(Components.interfaces.calICalendar) then only calICalendar). This is not needed if nsIClassInfo is implemented (correctly), since XPCOM can then find out what else the object implements and binds the methods on the wrapper.

Is the bug fixed just by implementing the QI and classInfo correctly? Or is the explicit calling of QI still needed with this patch?

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 633893 [details] [diff] [review]
explicitly call QueryInterface()

This patch is made obsolete by the other patch.

Comment 6

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/729da3db0e60

Comment 7

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/89781f55710c