Remove dead code about default toolbar in admin panel

REOPENED
Unassigned

Status

developer.mozilla.org
Code Cleanup
P5
normal
REOPENED
6 years ago
16 days ago

People

(Reporter: sheppy, Unassigned)

Tracking

Details

(Reporter)

Description

6 years ago
I followed groovecoder's instructions on using the admin panel to create a toolbar named "default" and edit it to set up a default toolbar but that toolbar is not being used. Being able to edit the toolbar is high priority, since the one we have kinda blows.

This should be fixed ahead of launch but it's not quite the end of life on earth if it misses (although not getting it fixed hurts productivity a lot).
Blocks: 756263
Component: Website → Docs Platform
QA Contact: website → docs-platform
Whiteboard: u=contributor c=wiki s=2012-07-03 p=
Blocks: 665691
No longer blocks: 756263

Comment 1

6 years ago
Maybe change this to "make the default toolbar on ckeditor usable"? I don't see why else the admins might need the ability to edit the default toolbar.

Sheppy, did you have the specific toolbar layout in mind? Here's what I think Mindtouch uses:

config.toolbar_Default =
  [
    ['MindTouchSave','MindTouchCancel','-','Source', 'ViewMenu','Preview'],
    ['Undo','Redo','-', 'RemoveFormat','PasteText','PasteFromWord','-','Find', 'Replace', 'ATDSpellChecker','-', 'Extensions','-','Maximize'],
    '/',
    ['NumberedList', 'BulletedList', '-', 'DefinitionList', 'DefinitionTerm', 'DefinitionDescription', '-', 'Blockquote', 'Outdent', 'Indent', 'CreateDiv'],
    ['MindTouchLink', 'Unlink', 'Anchor', '-', 'AttachImage','MindTouchImage', 'Table', 'InsertMenu', '-', 'TextColor', 'BGColor'],
    '/',
    ['Code','-','Bold','Italic','Underline','Strike', '-', 'Normal', 'H1', 'H2', 'H3', 'Hx', 'Styles', 'Transformations']
  ];

whereas kuma uses this config I think <https://github.com/mozilla/kuma/blob/master/apps/wiki/templates/wiki/ckeditor_config.js#L32> (although, confusingly, it also has this: https://github.com/mozilla/kuma/blob/master/media/js/ckeditor_config.js )
I'm fairly certain this file is currently being used for config:

/apps/wiki/templates/wiki/ckeditor_config.js
Whiteboard: u=contributor c=wiki s=2012-07-03 p= → u=contributor c=wiki s= p=
Ali: The team feels that this should not be a blocker for July. I am moving it out, but wanted to be sure to ping you for your thoughts.
Blocks: 756266
(Assignee)

Updated

6 years ago
Version: Kuma → unspecified
(Assignee)

Updated

6 years ago
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
No longer blocks: 756266
Priority: -- → P2
Summary: Kuma: Editing default toolbar in admin panel doesn't work → Editing default toolbar in admin panel doesn't work
Whiteboard: u=contributor c=wiki s= p=
Since we're waffling features and such, we wont be allowing the writing team to update this toolbar.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
We should also remove the code:

https://github.com/mozilla/kuma/blob/master/kuma/wiki/models.py#L1789-L1796
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Priority: P2 → P5
Summary: Editing default toolbar in admin panel doesn't work → Remove dead code about default toolbar in admin panel
Component: Editing → Code Cleanup
You need to log in before you can comment on or make changes to this bug.