Closed
Bug 765015
Opened 14 years ago
Closed 14 years ago
runtestsb2g.py assumes self.process has been created when handling errors
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(1 file)
|
2.46 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
The cleanup code calls self.server.stop(), however if an exception happens before the server (or mochitest) objects are instantiated then a second exception will occur and the original will be lost.
It might also help to print the traceback for exceptions (at least at the debug level).
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → ahalberstadt
|
|
Assignee | |
Comment 1•14 years ago
|
||
This patch also prints a traceback to stdout.
Attachment #633565 -
Flags: review?(jgriffin)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 633565 [details] [diff] [review]
Patch 1.0 - Fix error handling and print traceback
Review of attachment 633565 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #633565 -
Flags: review?(jgriffin) → review+
|
|
||
Comment 3•14 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•