Required input fields should have a required and aria-required attribute

VERIFIED FIXED in 2014-09

Status

addons.mozilla.org Graveyard
Public Pages
P5
enhancement
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: icaaq, Assigned: davidbgk)

Tracking

unspecified
2014-09

Details

(Whiteboard: [contribute][lang=html])

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0a1
Build ID: 20120614075912

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://addons.mozilla.org/en-US/firefox/users/register OR https://addons.mozilla.org/en-US/firefox/users/login?to=%2Fen-US%2Ffirefox%2Fusers%2Fregister
2. Click the Register OR Log in button


Actual results:

The form is submitted and a error message is displayed.


Expected results:

If a required attribute and a aria-required="true" attribute would be used many modern browsers would handle this required fields before it will be sent to the server for validation. Read more about it in the spec http://dev.w3.org/html5/spec/common-input-element-attributes.html#the-required-attribute and a good a11y writeup http://john.foliot.ca/required-inputs/
(Reporter)

Updated

5 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: normal → enhancement
Priority: -- → P5
Whiteboard: [contribute][lang=html]
Target Milestone: --- → 2014-04
Target Milestone: 2014-04 → 2014-06
Target Milestone: 2014-06 → 2014-07
Target Milestone: 2014-07 → 2014-08
(Assignee)

Comment 1

4 years ago
PR: https://github.com/mozilla/olympia/pull/210

For QA, there are screenshots on the PR, note that 3 forms are affected by that change.
Assignee: nobody → david
Target Milestone: 2014-08 → 2014-09
(Assignee)

Comment 2

4 years ago
https://github.com/mozilla/olympia/commit/51387c496f095dad3df853614a182f4b29de441e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 3

4 years ago
The form is still submitted for the Confirm Password field. Verified in https://addons-dev.allizom.org/en-US/firefox/users/register on FF32 (Win 7).
Please see screencast http://screencast.com/t/yL0Uczr4bpax
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

4 years ago
I'll solve that one as part of bug 1065178.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.