765147 - Required input fields should have a required and aria-required attribute

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P5)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0a1
Build ID: 20120614075912

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://addons.mozilla.org/en-US/firefox/users/register OR https://addons.mozilla.org/en-US/firefox/users/login?to=%2Fen-US%2Ffirefox%2Fusers%2Fregister
2. Click the Register OR Log in button


Actual results:

The form is submitted and a error message is displayed.


Expected results:

If a required attribute and a aria-required="true" attribute would be used many modern browsers would handle this required fields before it will be sent to the server for validation. Read more about it in the spec http://dev.w3.org/html5/spec/common-input-element-attributes.html#the-required-attribute and a good a11y writeup http://john.foliot.ca/required-inputs/

Comment 1

[David Larlet [:davidbgk]]

PR: https://github.com/mozilla/olympia/pull/210

For QA, there are screenshots on the PR, note that 3 forms are affected by that change.

Comment 2

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/51387c496f095dad3df853614a182f4b29de441e

Comment 3

[Iulian Timis]

The form is still submitted for the Confirm Password field. Verified in https://addons-dev.allizom.org/en-US/firefox/users/register on FF32 (Win 7).
Please see screencast http://screencast.com/t/yL0Uczr4bpax

Comment 4

[David Larlet [:davidbgk]]

I'll solve that one as part of bug 1065178.

Comment 5

[Iulian Timis]

Verified as fixed in https://addons.allizom.org/en-US/firefox/users/login , https://addons.allizom.org/en-US/firefox/users/pwreset and https://addons.allizom.org/en-US/firefox/users/register on FF32 (Win 7).
Closing bug.