765151 - Don't load syncNode from LDAP when check_node is False

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch to only load syncNode if needed

The new-style auth backend unconditionally loads syncNode from LDAP, even though it won't be checked is check_node is False.  This appears to break loadtesting on stage because those accounts do not have syncNode set in LDAP.

Attached patch changes it to only load syncNode if it's actually going to be checked.

Comment 1

[Rob Miller [:rmiller]]

Comment on attachment 633414 [details] [diff] [review]
patch to only load syncNode if needed

Review of attachment 633414 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/wsgiauth.py
@@ +175,5 @@
>                  else:
> +                    if check_node:
> +                        if user.get('syncNode') != environ.get('HTTP_HOST'):
> +                            user_id = None
> +                            user = None

Any reason you switched from using an 'and' clause to nested 'if' statements? Not a big deal, just wondering if it was intentional...

Comment 2

[Ryan Kelly [:rfkelly]]

Hmmm, you know, I don't even remember doing that!  Must have thought it looked cleaner at the time, but it's really much the same.  Committed with the 'and' clause reinstated to reduce pointless churn:

http://hg.mozilla.org/services/server-core/rev/563b02c2d03f