Typo in importScript would fail to use importedScripts

RESOLVED FIXED

Status

Testing
Marionette
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Minor typo and probably isnt being used yet

file = FileUtils.openFileOutputStream(importedScripts, FielUtils.MODE_APPEND);
(Assignee)

Comment 1

6 years ago
Created attachment 633533 [details] [diff] [review]
fix for the typo
Attachment #633533 - Flags: review?(mdas)
Comment on attachment 633533 [details] [diff] [review]
fix for the typo

Review of attachment 633533 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! We should add a test case for this code path before landing it
Attachment #633533 - Flags: review?(mdas) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 633997 [details] [diff] [review]
Fix for appending to file and a test case to prove
Attachment #633533 - Attachment is obsolete: true
Attachment #633997 - Flags: review?(mdas)
(Assignee)

Updated

6 years ago
Assignee: nobody → dburns
Comment on attachment 633997 [details] [diff] [review]
Fix for appending to file and a test case to prove

Review of attachment 633997 [details] [diff] [review]:
-----------------------------------------------------------------

Looks really good, thanks for the patch!
Attachment #633997 - Flags: review?(mdas) → review+
(Assignee)

Comment 5

6 years ago
landed in https://hg.mozilla.org/mozilla-central/rev/373e6f9264e6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.