765249 - modify release cfg email recipient address format to prevent spam classification

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[hwine]

bug 756259 comment #36 proposes a change to workaround release automation emails being classified as spam. Basically, it is to use a "less ambiguous" recipient address format.

Since that might be an easy textual change easily in our control, seems worth a test.

Comment 1

[hwine]

Test works! Here's an email from buildbot:
    Return-Path: [e-mail]
    Received: from zmmta2.mail.corp.phx1.mozilla.com (LHLO
     zmmta2.mail.corp.phx1.mozilla.com) (10.20.77.30) by
     zmmbox4.mail.corp.phx1.mozilla.com with LMTP; Fri, 15 Jun 2012 12:45:03
     -0700 (PDT)
    Received: from smtp.mozilla.org (zlb1.mail.corp.phx1.mozilla.com [10.20.77.200])
            by zmmta2.mail.corp.phx1.mozilla.com (Postfix) with ESMTP id 1E38B1020C3
            for <[e-mail]>; Fri, 15 Jun 2012 12:45:03 -0700 (PDT)
    X-Virus-Scanned: amavisd-new at mozilla.org
    X-Spam-Flag: NO
    X-Spam-Score: -8.301
    X-Spam-Level: 
    X-Spam-Status: No, score=-8.301 required=6.31 tests=[AM:BOOST=-8,
            BAYES_00=-1.5, MISSING_MID=1.199] autolearn=no
    Received: from dev-master01.build.scl1.mozilla.com (unknown [63.245.222.66])
            by mx1.mail.corp.phx1.mozilla.com (Postfix) with ESMTPS id DF5FBF256D
            for <[e-mail]>; Fri, 15 Jun 2012 12:45:02 -0700 (PDT)
    Content-Transfer-Encoding: base64
    MIME-Version: 1.0
    Content-Type: text/plain; charset="utf8"
    Date: Fri, 15 Jun 2012 12:45:02 -0700
    Subject: [staging-release] Firefox 12.0b3 build1: All win32 builds now
            available
    From: [e-mail]
    To: <[e-mail]>
    Message-Id: <[e-mail]>

    QWxsIHdpbjMyIGJ1aWxkcyBub3cgYXZhaWxhYmxlCgpmdHA6Ly9kZXYtc3RhZ2UwMS5zcnYucmVs
    ZW5nLnNjbDMubW96aWxsYS5jb20vcHViL21vemlsbGEub3JnL2ZpcmVmb3gvbmlnaHRseS8xMi4w
    YjMtY2FuZGlkYXRlcy9idWlsZDEvd2luMzIKCi1idWlsZGJvdAoK

The above email demonstrates:
    - using '<>' delimiters on recipient email addresses is supported by
      our buildbot code
    - using '<>' delimiters doesn't incure the TO_NO_BRKTS_DIRECT
      penalty (+4 pts), which is enough to keep our messages from being
      spam
    - we'd be okay with removing the -8 pts for AM:BOOST, in case that
      is too easily spoofed by real spam

Comment 2

[hwine]

Attachment: email address changes

Found all instances of emails needing to be changed with:
 egrep -rn "([\"'])[^<][^@\w]+@[^\w']+[^>]\1" . | grep -v ^Binary | egrep 'ecipient|email'
from the top level of buildbot-configs - 70 lines in 28 files needed changing. After some happy vimming (love macros & text objects), test via:
 $ egrep -rn "([\"'])[^<][^@\w]+@[^\w']+[^>]\1" . | grep -v ^Binary | egrep 'ecipient|email' | wc -l
       0

Will verify they all pass config check before committing.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 633723 [details] [diff] [review]
email address changes

Just driving by and noticed there are places where akeybl@ is explicity stated - can that be updated to release-mgmt@ so all Release Managers get the emails?

Comment 4

[hwine]

Comment on attachment 633723 [details] [diff] [review]
email address changes

r=catlee on irc

tweaked slightly from above as bug 765715 landed first

Comment 5

[hwine]

(In reply to Hal Wine [:hwine] from comment #4)
http://hg.mozilla.org/build/buildbot-configs/rev/7ec525209823

Comment 6

[hwine]

In production as of Monday's reconfig