765292 - Expose build locale in Socorro

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Robert Kaiser]

Once bug 765288 is done, we should expose that info in Socorro. We probably want that in reports_clean or such as well as we might want to expose that in multiple places in the future.
For the first step, I'd like to have that exposed in the individual crash report pages, having it exposed in reports list and signature summary as well would be very good.
Everything further we'll see in the future, but we probably will want to be able at some point to get top crashes on a certain locale or things like that.

Comment 1

[Robert Kaiser]

https://crash-stats.mozilla.com/rawdumps/b2e4ddc3-28bc-4e24-becc-aee902130829.json
includes this piece:
useragent_locale": "en-US",

Let's get this into report/index, ideally also into a signature summary.

Comment 2

[Schalk Neethling [:espressive]]

From what I can see, we are already exposing the locale under the metadata tab on report/index

For report/list, from what I can see, the middleware does not yet expose this (nor does any of the signature summary services) to the Django side and thus it cannot be displayed.

Should be changed to a middleware bug for the time being?

Comment 3

[Lonnen :lonnen]

The component doesn't matter so much.

Comment 4

[Schalk Neethling [:espressive]]

KaiRo, currently this is exposed, as mentioned, under the metadata tab on report/index. Now, for report list, do you want it exposed both under signature summary and the reports tab or just signature summary?

Also, under signature summary, would this be added to the table product or, perhaps under more than one section? Thanks!

Comment 5

[Robert Kaiser]

(In reply to Schalk Neethling [:espressive] from comment #4)
> KaiRo, currently this is exposed, as mentioned, under the metadata tab on
> report/index. Now, for report list, do you want it exposed both under
> signature summary and the reports tab or just signature summary?

I think making sure it's on the (white)lists to show up in SuperSearch and the selectable columns for the Reports tab on report/list is enough. Back when I filed this we didn't have either of them or the metadata tab on individual reports yet. ;-)

> Also, under signature summary, would this be added to the table product or,
> perhaps under more than one section? Thanks!

It may be interesting to add a signature summary section for it, but let's not do this for now.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Steps to add a new field to Super Search are described here: https://bugzilla.mozilla.org/show_bug.cgi?id=1057319#c2

Comment 7

[Schalk Neethling [:espressive]]

(In reply to Adrian Gaudebert [:adrian] from comment #6)
> Steps to add a new field to Super Search are described here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1057319#c2

Thanks, useragent_locale is already in the whitelist for rawcrash
https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/crashstats/models.py#L961

So that means it can now be created as a new field in super search right?

Comment 8

[Schalk Neethling [:espressive]]

So something to this effect:

* Name = useragent_locale
* Namespace = raw_crash
* Name in database = useragent_locale
* Description = The reported User-Agent locale
* Query type = enum [What determines this value?]
* Data type = enum [What determines this value?]
* Permissions needed = none [Probably not]
* Form field choices = none [What determines this value?]
* Is exposed = yes
* Is returned = yes
* Has full version = no [What determines this value?]
* Storage mapping = {"type": "string"} [This just returns something like en-US so, I guess string is just fine?]

Also, I do not seem to have access to the admin on stage so, Adrian, Kairo, can you give this a go? Thanks!

Comment 9

[Schalk Neethling [:espressive]]

Or if someone could give me the required access on stage, that would be even better ;)

Comment 10

[[DEACTIVATED] Adrian Gaudebert]

useragent_locale actually already is in Super Search Fields. No need to add it. :)

http://socorro.readthedocs.org/en/latest/elasticsearch.html#master-list-of-fields answers some of your questions. I'll add more details right now so it is even more complete!

Comment 11

[Schalk Neethling [:espressive]]

(In reply to Adrian Gaudebert [:adrian] from comment #10)
> useragent_locale actually already is in Super Search Fields. No need to add
> it. :)
> 
> http://socorro.readthedocs.org/en/latest/elasticsearch.html#master-list-of-
> fields answers some of your questions. I'll add more details right now so it
> is even more complete!

Awesome thanks Adrian!

Comment 12

[Schalk Neethling [:espressive]]

To update the status of this bug then:

It is exposed under the metadata tab on report/index

It is available under super search

TO-DO
------

Expose on the reports tab, report/list

Comment 13

[Schalk Neethling [:espressive]]

And finally, just found out from Adrian that it is already available under the reports tab as one of the available columns so, I am going to close this one as resolved.