Closed Bug 765294 Opened 8 years ago Closed 8 years ago

Fix packaging of services modules

Categories

(Cloud Services :: Firefox: Common, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: gps, Assigned: gps)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

I just noticed that the packaging on AITC wasn't done completely correctly.

Specifically, its inclusion in applications is dependent on MOZ_SERVICES_SYNC. IMO, we should have a separate variable (MOZ_SERVICES_AITC, etc) or just not conditionally include AITC.

Patch is forthcoming.
Attached patch Packaging changes to AITC, v1 (obsolete) — Splinter Review
Try at https://tbpl.mozilla.org/?tree=Try&rev=ec1abfc42c40

I have no clue if I did all this right. These are parts of the build system I'm still not too familiar with.
Attachment #633578 - Flags: review?(ted.mielczarek)
Changing to also include unborking notifications.
Assignee: gps → nobody
Component: AppsInTheCloud → Firefox: Common
Product: Web Apps → Mozilla Services
QA Contact: appsync → firefox-common
Summary: Package AITC Properly → Fix packaging of services modules
Pulled in changes from notifications packaging (bug 754062). The notifications foo actually has services-central orange right now.
Assignee: nobody → gps
Attachment #633578 - Attachment is obsolete: true
Attachment #633578 - Flags: review?(ted.mielczarek)
Attachment #633607 - Flags: review?(ted.mielczarek)
Blocks: 754062
Attachment #633607 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/services/services-central/rev/be2ab5deb078

Thanks, Ted!
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla16
Whiteboard: [fixed in services] → [fixed in services][qa-]
https://hg.mozilla.org/mozilla-central/rev/be2ab5deb078
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.