Comment 1 AWAY Tom Schuster [:evilpie] 2012-06-16 09:52:25 PDT

Created attachment 633822 [details] [diff] [review]
actual fix

Comment 2 David Anderson [:dvander] 2012-06-18 15:26:43 PDT

Comment on attachment 633822 [details] [diff] [review]
actual fix

Review of attachment 633822 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Stack.h
@@ +57,5 @@
>  struct InlinedSite {};
>  #endif
>  typedef size_t FrameRejoinState;
>  
> +#ifdef JS_ION

No #ifdef's needed here.

@@ +487,3 @@
>      /* Called from IonMonkey to transition from bailouts. */
>      void initFromBailout(JSContext *cx, ion::SnapshotIterator &iter);
> +#endif

No #ifdefs needed here.

@@ +1668,5 @@
>  
>      /* Bailout for normal functions. */
>      StackFrame *pushBailoutFrame(JSContext *cx, const ion::IonBailoutIterator &it,
>                                   const CallArgs &args, BailoutFrameGuard *bfg);
> +#endif

No #ifdefs needed here.

Comment 3 AWAY Tom Schuster [:evilpie] 2012-07-02 08:09:54 PDT

I actually landed that?
http://hg.mozilla.org/projects/ionmonkey/rev/6722bb3c5549/

I still need to fix threadsafe builds to make tbpl happy.

Comment 4 AWAY Tom Schuster [:evilpie] 2012-07-02 11:34:28 PDT

https://hg.mozilla.org/projects/ionmonkey/rev/5d3e8c9dc6f8

Wasn't a NSPR issue after all, but in case this is giving you issues locally, you need a pretty recent version of NSPR (something with Bug 758837).