Register PrefChanged for CUBEB_LATENCY_MS so the pref has an effect

RESOLVED FIXED in mozilla16

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 633851 [details] [diff] [review]
patch v0
Attachment #633851 - Flags: review?(cpearce)
(Assignee)

Updated

5 years ago
Attachment #633851 - Attachment is obsolete: true
Attachment #633851 - Flags: review?(cpearce)
(Assignee)

Comment 2

5 years ago
Created attachment 633862 [details] [diff] [review]
patch v1

Same intent as previous patch, but need to pass a default to GetUint, otherwise it returns 0 and we end up forcing the minimum latency (20ms) when the pref is unset.  This version removes the default initializers for all of the prefs, since they should never be used before they're initialized and it's confusing to have a default value here and where the pref is fetched.

Also removes references to unused mozilla::TimeStamp.
Attachment #633862 - Flags: review?(cpearce)
Attachment #633862 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e22422f1cc59
OS: Windows 7 → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla16

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e22422f1cc59
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.