765605 - Kuma: NoReverseMatch: Reverse for 'wiki.tag' with arguments '(u'File I/O',)' and keyword arguments '{}' not found.

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Les Orchard [:lorchard]]

It appears that the tagging system has problems with slashes in tag names. And, as it turns out, there are tags with slashes in them.

Traceback (most recent call last):

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django-waffle/waffle/decorators.py", line 20, in _wrapped_view
    return view(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/views/decorators/http.py", line 37, in inner
    return func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/views.py", line 153, in process
    return func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/views/decorators/http.py", line 124, in inner
    response = func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/views.py", line 361, in document
    response = jingo.render(request, 'wiki/document.html', data)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/jingo/jingo/__init__.py", line 78, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
    return template.render(**get_context())

  File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/templates/wiki/document.html", line 15, in top-level template code
    {% set help_link = url('wiki.translate', document_path=document.parent.full_path, locale=document.parent.locale)|urlparams(tolocale=request.locale) %}

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/templates/wiki/base.html", line 12, in top-level template code
    {% set scripts = ('wiki',) %}

  File "/data/www/developer.mozilla.org/kuma/templates/base.html", line 153, in top-level template code
    {% block content %}{% endblock %}

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/templates/wiki/document.html", line 180, in block "content"
    <a class="text" href="{{url('wiki.tag', tag.name)}}">{{ tag.name }}</a>

  File "/data/www/developer.mozilla.org/kuma/apps/sumo/helpers.py", line 39, in url
    return reverse(viewname, args=args, kwargs=kwargs, locale=locale)

  File "/data/www/developer.mozilla.org/kuma/apps/sumo/urlresolvers.py", line 51, in reverse
    url = django_reverse(viewname, urlconf, args, kwargs, prefix)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/core/urlresolvers.py", line 351, in reverse
    *args, **kwargs)))

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/core/urlresolvers.py", line 297, in reverse
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'wiki.tag' with arguments '(u'File I/O',)' and keyword arguments '{}' not found.


<WSGIRequest
GET:<QueryDict: {u'redirectlocale': [u'en-US'], u'redirectslug': [u'nsIFile']}>,
POST:<QueryDict: {}>,
COOKIES:{},
META:{'CSRF_COOKIE': '427b85dfeff76b1b5be08faf8a71d191',
 'DOCUMENT_ROOT': '/data/www/developer.mozilla.org/kuma/webroot',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTPS': 'on',
 'HTTP_ACCEPT': '*/*',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
 'HTTP_CONNECTION': 'Keep-alive',
 'HTTP_FROM': 'googlebot(at)googlebot.com',
 'HTTP_HOST': 'developer-new.mozilla.org',
 'HTTP_SSLCLIENTCERTSTATUS': 'NoClientCert',
 'HTTP_SSLCLIENTCIPHER': 'SSL_RSA_WITH_RC4_128_SHA, version=TLSv1, bits=128',
 'HTTP_SSLSESSIONID': 'D05EFF347ED417C61CE782FFF1CE8497A77F0BBAA0EA5625549D32C7B2D3E6B8',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)',
 'HTTP_X_CLUSTER_CLIENT_IP': '66.249.71.46',
 'PATH_INFO': u'/en-US/docs/XPCOM_Interface_Reference/nsIFile',
 'PATH_TRANSLATED': '/data/www/developer.mozilla.org/kuma/wsgi/kuma.wsgi/en-US/docs/XPCOM_Interface_Reference/nsIFile',
 'QUERY_STRING': 'redirectlocale=en-US&redirectslug=nsIFile',
 'REMOTE_ADDR': '10.22.81.210',
 'REMOTE_PORT': '44555',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/en-US/docs/XPCOM_Interface_Reference/nsIFile?redirectlocale=en-US&redirectslug=nsIFile',
 'SCRIPT_FILENAME': '/data/www/developer.mozilla.org/kuma/wsgi/kuma.wsgi',
 'SCRIPT_NAME': u'',
 'SCRIPT_URI': 'http://developer-new.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIFile',
 'SCRIPT_URL': '/en-US/docs/XPCOM_Interface_Reference/nsIFile',
 'SERVER_ADDR': '10.22.81.19',
 'SERVER_ADMIN': '[e-mail]',
 'SERVER_NAME': 'developer-new.mozilla.org',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '',
 'SERVER_SOFTWARE': 'Apache',
 'mod_wsgi.application_group': 'developer.mozilla.org|',
 'mod_wsgi.callable_object': 'application',
 'mod_wsgi.handler_script': '',
 'mod_wsgi.input_chunked': '0',
 'mod_wsgi.listener_host': '',
 'mod_wsgi.listener_port': '81',
 'mod_wsgi.process_group': 'developer',
 'mod_wsgi.request_handler': 'wsgi-script',
 'mod_wsgi.script_reloading': '1',
 'mod_wsgi.version': (3, 3),
 'platform.name': 'developer2.webapp.scl3.mozilla.com',
 'wsgi.errors': <mod_wsgi.Log object at 0x7f6d7aa98cb0>,
 'wsgi.file_wrapper': <built-in method file_wrapper of mod_wsgi.Adapter object at 0x7f6d7aa99be8>,
 'wsgi.input': <mod_wsgi.Input object at 0x7f6d7aa98930>,
 'wsgi.loaded': datetime.datetime(2012, 6, 17, 10, 49, 18, 834910),
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'https',
 'wsgi.version': (1, 1)}>

Comment 1

[Lucian Ursu [:bahamas]]

Added fix and sent pull request https://github.com/mozilla/kuma/pull/286

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c6001519ab2976a6fa239723f7a92e1989c9eee4
Merge pull request #286 from LucianU/b-765605

fix bug 765605: Modified url pattern to allow slashes in tag names