765783 - Implement event specific signup page

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Pierros Papadeas [:pierros]]

Based on 764893 we should be able to provide a Get Involved page that once someone signs up it notifies reps.mozilla.org with this signup to keep a count of signups per Rep event. 

This can be done with code linked to the submit button that uses a trailing identifier on URI (e.g. ?event=Sample_Event ) so that it posts this info back to reps.mozilla.org so we can track it.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Pierros,

Please implement the visuals for the new events /contribute page. Note that we can dynamically alter some parts (e.g. 'Event Name') with javascript and url arguments, if needed. When done please re-assign to me.

Comment 2

[Pierros Papadeas [:pierros]]

I see no reason in changing the appearance of Get Involved page (other than amending the URL) Do you have something specific in mind?

Comment 3

[Giorgos Logiotatidis [:giorgos]]

I thought we are changing it to something simpler, 'fullscreen ready'. There is too much information in this one. I prefer something like the one fuxyfox coded for FOSDEM

Comment 4

[Pierros Papadeas [:pierros]]

No need to do it as the first implementation. Please go ahead and code using the current /contribute looks and feel.

Thanks!

Comment 5

[Ben (:bensternthal)]

Adding a sec review on this based on comments in the pull request:

https://github.com/mozilla/bedrock/pull/183

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3425f80b426ccdab28cf4237c4b98a90bae8cab9
[fix bug 765783] Implement callback url support.

- For each successful subscription in /contribute we POST to
  callbackurl GET parameter if available.

- Added /contribute/event/ page that renders the same page as
  /contribute but returns user to the same page after successfull
  subscription, so a new user can directly join.

Conflicts:
	apps/mozorg/urls.py
	apps/mozorg/views.py

Comment 8

[Anthony Ricaud (:rik)]

This has been pushed to production.

Comment 9

[Giorgos Logiotatidis [:giorgos]]

I noticed that there a race condition going on between the two POST attempts. 

Details:
1. If callbackurl URL parameters is present, during 'help-form' submit we also POST to callbackurl.

2. Because the 'help-form' POST loads another page, they Ajax POST to callbackurl might get aborted, if it's not completed by the time browser requests the new page.

I re-wrote the form submit handling code, so that we pause 'help-form' submission until the POST to callbackurl is finished.

https://github.com/mozilla/bedrock/pull/338

Comment 10

[Steven Garrity [:sgarrity]]

(In reply to [github robot] from comment #7)
> https://github.com/mozilla/bedrock/commit/
> 3425f80b426ccdab28cf4237c4b98a90bae8cab9
> [fix bug 765783] Implement callback url support.

Giorgos, the change to urls.py in this commit appears to have broken the /contribute/page page.

http://www.mozilla.org/contribute/page is loading the contents of /mozorg/templates/mozorg/contribute.html rather than /mozorg/templates/mozorg/contribute-page.html

Comment 11

[Giorgos Logiotatidis [:giorgos]]

(In reply to Steven Garrity from comment #10)
> (In reply to [github robot] from comment #7)
> > https://github.com/mozilla/bedrock/commit/
> > 3425f80b426ccdab28cf4237c4b98a90bae8cab9
> > [fix bug 765783] Implement callback url support.
> 
> Giorgos, the change to urls.py in this commit appears to have broken the
> /contribute/page page.
> 

I'm really sorry I messed this up :( I got that right on 'dev' branch but then I had to PR again for 'master' 

Here is a PR with a fix https://github.com/mozilla/bedrock/pull/357

Thanks and again sorry for that.

-g

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/806a1926727864e2567545df6431ca20a8f48b99
[bug 765783] Restore /contribute/page.

Comment 13

[Osmose [:osmose, :mkelly]]

Pushed and verified on stage and master. Looks good, nice work!

Comment 14

[Giorgos Logiotatidis [:giorgos]]

Reopening this one, since we have another PR waiting


https://github.com/mozilla/bedrock/pull/338

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8dc7b8940c7b6c6434218c3b3d671ac0db0921e7
[fix bug 765783] POST form after POST to callback_url is complete.

https://github.com/mozilla/bedrock/commit/2f7189b032201de4c6f77e65d091ccd9d2dd6013
Merge pull request #338 from glogiotatidis/implement-contribute

[fix bug 765783] POST form after POST to callback_url is complete.

Comment 16

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/72e75584a3103ab26503a4b7a773c07468e106f2
[bug 765783] Merge two views into one to keep it DRY.

https://github.com/mozilla/bedrock/commit/b1a2803147e233eed5ad921518997d4ce043dc4f
[fix bug 765783] Implement callback url support.

- For each successful subscription in /contribute we POST to
  callbackurl GET parameter if available.

- Added /contribute/event/ page that renders the same page as
  /contribute but returns user to the same page after successfull
  subscription, so a new user can directly join.

https://github.com/mozilla/bedrock/commit/a6cc56dd47c90058f4b9c450962869aba86f6c67
[fix bug 765783] Implement callback url support.

- For each successful subscription in /contribute we POST to
  callbackurl GET parameter if available.

- Added /contribute/event/ page that renders the same page as
  /contribute but returns user to the same page after successfull
  subscription, so a new user can directly join.

Comment 17

[Anthony Ricaud (:rik)]

This has been pushed to production.