765824 - Data points do not line up on X axis

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: Data point not lined up

Steps to reproduce:
1) Load a stats page: https://addons.mozilla.org/en-US/firefox/addon/firebug/statistics/?last=30
2) Hover over a date.
3) Notice the data point does not line up with the date on the X axis.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Attachment: Also reproducible on Marketplace

Comment 2

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/305cb0f5cd513bcc3a4a7b5da1a060d44a03c1ed

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Attachment: Data points on X axis not lining up

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Reopening re: comment 3

Comment 5

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/a7fac9438a014721c5e6fbe462d4b9d2191a4605

Let's try this.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Unfortunately it looks like this is still a problem. See https://marketplace-dev.allizom.org/en-US/app/seevans-underworld-adventur/statistics/:

http://cl.ly/0y403L3x0O212b2f462Q

FWIW, it does look much better than it previously did.

Comment 7

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/4a125b1743620bd7a911dfdfc8cb6e6860f30da3

This fixes the root cause, and this bug is dead.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

looks awesome