765893 - Stack traces should include abc name

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Alex Macdonald]

Attachment: stack-trace-improvement.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.56 Safari/536.5

Steps to reproduce:

It isn't currently posible to differentiate script init function call frames with in a stack trace. This patch stores the name of the ABC (from the SWF doABCTag) so that stack traces can include this information.

This is especially useful when a SWF contains multiple ABC blocks and a crash occurs during initialization when multiple script init functions end up on the call stack.

Instead of seeing this:

...
at global$init()
at global$init()
...


You would see this:

...
at global$init() <ABC1>
at global$init() <ABC2>
...

(where ABC1/ABC2 are strings coming from the SWF)

Comment 1

[Tom Rodriguez]

This change looks good to me.  I'll send it through shelf builder to make sure it's clean and get a superreview from Felix.

Comment 2

[Tom Rodriguez]

Comment on attachment 634154 [details] [diff] [review]
stack-trace-improvement.patch

I had done a manual avmshell build and it looked fine but I did a full shelf build and there's a problem with the overriding in the larger product.  I'm looking into.

Comment 3

[Tom Rodriguez]

Comment on attachment 634154 [details] [diff] [review]
stack-trace-improvement.patch

Review of attachment 634154 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  The patch was taken as is.

Comment 4

[Tamarin Bot]

changeset: 7475:4c627946b395
user:      Tom Rodriguez <[e-mail]>
summary:   Bug 765893: Stack traces should include abc name (p=alexmac, r+throdrig, sr+fklockii)

http://hg.mozilla.org/tamarin-redux/rev/4c627946b395

Comment 5

[Tamarin Bot]

changeset: 7476:b7c9c2eba6dd
user:      Tom Rodriguez <[e-mail]>
summary:   Bug 773064: Fix for 765893 missed avmplusDebuggerStubs.cpp (r=fklockii)

http://hg.mozilla.org/tamarin-redux/rev/b7c9c2eba6dd

Comment 6

[Tom Rodriguez]

Fixed as CL 1086312