Created attachment 634184 [details] [diff] [review] cygwin.patch User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.56 Safari/536.5 Steps to reproduce: Cygwin has lots of quirks that prevent compilation, this patch fixes those compilation errors mostly by providing stubs that abort at runtime, but I have yet to see them hit in practice.
Comment on attachment 634184 [details] [diff] [review] cygwin.patch Looks fine. A bit inconsistent as to whether comments are inside or outside the ifdef blocks. For what it's worth, I think inside is usually better since the association between the comment and the code is less likely to be damaged by subsequent edits.
Attachment #634184 - Flags: review+
You need to log in before you can comment on or make changes to this bug.