make xpcshell and mozmill tests pass with maildir as default pluggable store

NEW
Unassigned

Status

MailNews Core
Backend
6 years ago
3 years ago

People

(Reporter: Bienvenu, Unassigned)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
There are several unit test failures that show up when I run with a build that defaults pluggable stores to maildir. I'm going to put the patches that fix those issues in this bug..
(Reporter)

Comment 1

6 years ago
Created attachment 634212 [details] [diff] [review]
fix maildir store token for fake headers - checked in.

The pluggable stores set the store token when you call GetNewMsgOutputStream, so the imap mail folder object shouldn't do so. The store also sets the message offset. The imap mail folder code was basically assuming berkeley mailbox, which doesn't work with maildir.

The removal of the srcKeyArray and srcMsgs is an unrelated change, but those variables aren't used.
Attachment #634212 - Flags: review?(neil)

Updated

6 years ago
Attachment #634212 - Flags: review?(neil) → review+
(Reporter)

Updated

6 years ago
Attachment #634212 - Attachment description: fix maildir store token for fake headers → fix maildir store token for fake headers - checked in.
(Reporter)

Comment 2

6 years ago
maildir store token patch checked in - http://hg.mozilla.org/comm-central/rev/8c820d9d2612

Updated

5 years ago
Blocks: 786595

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All

Comment 3

5 years ago
Patch has been backed out in Bug 786595 due to incorrect message body being displayed in certain circumstances.

Updated

5 years ago
Blocks: 845952

Updated

5 years ago
No longer blocks: 786595
Depends on: 786595

Updated

3 years ago
Assignee: mozilla → nobody
Depends on: 1011399
Blocks: 1135309
No longer blocks: 1135309
You need to log in before you can comment on or make changes to this bug.