765949 - Persona Branding Update

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Wilson Guaraca]

Hi  all,
I am opening this bug to make sure we change the branding of BrowserID to the new Persona branding. 

Here are the guidelines for this change: 
http://people.mozilla.org/~smartell/persona/#branding

Comment 1

[Stuart Parmenter]

I think we mainly need better Mozilla Persona logo for the login page and a larger signin button than the ones on that page (similar to the Pancake on on that page though?) (both with retina sizes)

Comment 2

[Deb Richardson [:dria] (plz NEEDINFO)]

Is all of the BrowserID branding on our side and under our control?  I notice a bunch of it when actually logging in through Persona, which I thought was done on the Persona site directly.

Comment 3

[Stuart Parmenter]

This set of stuff is under our control

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: button graphics

The only place this should impact in our first run experience is the Sign In screen, here: http://cl.ly/3S0s201u0Z2l0x0n2Q2A

Attached are graphics for the Persona sign in button.

Comment 5

[Gordon Brander :gordonb]

Fixed by https://bitbucket.org/mozillapancake/pancake/changeset/3f14d8545e34.

The image attached to the bug shows a page without the Pancake logo. However, since the logo was specifically requested by Stuart, I'm going to assume we're trying to abide by the spirit of the comp, rather than a pixel-perfect implementation. Please re-open if I misunderstood.

Comment 6

[Gordon Brander :gordonb]

Update: the previous commit actually broke the JavaScript bindings for Persona signin, which are tied to elements with class .browserid-button. This issue is fixed by https://bitbucket.org/mozillapancake/pancake/changeset/fa8a1dd78c58.

Reopening to change classname to .persona-button.

Comment 7

[Gordon Brander :gordonb]

Fixed by https://bitbucket.org/mozillapancake/pancake/changeset/71b8ceeb709c. Changed .browserid-button to #persona-signin.

Comment 8

[Gordon Brander :gordonb]

The disabled state for persona was missed when this bug was closed.

Comment 9

[Gordon Brander :gordonb]

Fixed by https://bitbucket.org/mozillapancake/pancake/changeset/65e6b62d3d33.
My sincere apologies for missing it earlier.