76596 - Manually closing a JAR input stream crashes mozilla

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

If js code explicitly closes a JAR input stream, the stream crashes as it 
destructs.

The "Close()" method of the stream is a public method, and is also called by 
the object destructor.  However, the close method does not guard against being 
called twice, and therefore attempts to free memory twice.

Attaching a patch that fixes the crash by resetting the freed pointer to null.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Patch that allows close to be called multiple times

Comment 2

[Brendan Eich [:brendan]]

Good catch, it's a bad pattern we've seen in other (mailnews consumed) stream
impls.  Who should review the patch?  I can give it r/sr=[e-mail]. 
Should it get into 0.9?  Reassigning based on cvs annotate output.

/be

Comment 3

[Doug Turner (:dougt)]

Deleting a null pointers is a no-op, a simplier patch is just the null 
assignment.  r=dougt.  

Comment 4

[Daniel Veditz [:dveditz]]

The code seems to have already changed in this area.