76598 - Crash Trying to Rename PT items

Status: VERIFIED DUPLICATE of bug 76715

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jason Kersey]

repro:
make sure you have items on your personal toolbar first.

.rename an item using the context menu
.continue renaming until it stops working
.bring another window into focus
.go back to original window
.crash

tb id is tb29299719m

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

"Until it stops working" is the important note ;)

It shouldn't stop working. Here's why it does: Focus shifts from one of the 
valid focusable elements (the edit field, the urlbar, etc) into something else, 
or maybe into nothing. As a result the controllers array seems to "change." 
There is one controller in it, the editor controller. 

I wouldn't be surprised if there is something very wrong here, and that this is 
leading to the crash. 

I saw this yesterday, but can't seem to reproduce it anymore. Trying harder 
now...

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch that fixes crash

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

OK, so here's what seems to be happening:

the il field seems to still have focus (somehow, some way) when the window 
deactivates. Whatever mechanism notes down which element is focused so that this 
can be restored when the window is reactivated records this. However the blur 
handler in the binding for the il toolbar buttons tears the field out of the 
document. 

The window is reactivated, the NS_ACTIVATE case in 
nsEventStateManager::PreHandleEvent gets the focused content and tries to call 
SetFocus on it (which ends up in nsHTMLInputElement::SetFocus). Unfortunately 
mDocument of that is null, and boom. So I added a check that a document exists 
for the focused content before trying to set focus. 

Copying chris & dave for r/sr=

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

updated the patch in my tree to call the nsIDocument COMPtr 'contentDoc' rather 
than 'elementDoc'

Comment 5

[David Hyatt]

This bug should be duped on a fix waterson already made and is going to check 
in today.

Comment 6

[John Morrison]

did you mean bug 76715? (which waterson punted back to hyatt, by the way).

Comment 7

[André Dahlqvist]

Or perhaps bug 68451?

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

sure.

the setAttribute bug is different, I think. 

*** This bug has been marked as a duplicate of 76715 ***

Comment 9

[Claudius Gayle]

VERIFIED Dupe