Closed
Bug 766007
Opened 9 years ago
Closed 9 years ago
Create scrollframes for frameset documents
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
2.54 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
We might as well. Framesets aren't common, the optimization of avoiding scrollframes is insigificant, and it simplifies things across mobile and desktop and reduces the number of different code paths.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #634269 -
Flags: review?(tnikkel)
Comment 2•9 years ago
|
||
Comment on attachment 634269 [details] [diff] [review] fix I guess content can't do anything silly like create scrollbars by applying an overflow style or something to the root or body element?
Assignee | ||
Comment 3•9 years ago
|
||
It actually can; html.css has "frameset { overflow: -moz-hidden-unscrollable; }", so content can override it. However, I think that's a feature. Note that currently content can add scrollframes to non-root <frameset>s.
Comment 4•9 years ago
|
||
Comment on attachment 634269 [details] [diff] [review] fix Ok.
Attachment #634269 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/419f0d1b848b
Comment 6•9 years ago
|
||
Backed out due to perma orange on Moth, see: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8661c74deeb5 https://hg.mozilla.org/integration/mozilla-inbound/rev/ef1c6a327b0d
Assignee | ||
Comment 7•9 years ago
|
||
This didn't seem to be the cause of the orange. Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/e828ff0dbc94
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e828ff0dbc94
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•