Closed Bug 766007 Opened 8 years ago Closed 8 years ago

Create scrollframes for frameset documents

Categories

(Core :: Layout, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

We might as well. Framesets aren't common, the optimization of avoiding scrollframes is insigificant, and it simplifies things across mobile and desktop and reduces the number of different code paths.
Attached patch fixSplinter Review
Attachment #634269 - Flags: review?(tnikkel)
Comment on attachment 634269 [details] [diff] [review]
fix

I guess content can't do anything silly like create scrollbars by applying an overflow style or something to the root or body element?
It actually can; html.css has "frameset { overflow: -moz-hidden-unscrollable; }", so content can override it. However, I think that's a feature. Note that currently content can add scrollframes to non-root <frameset>s.
Comment on attachment 634269 [details] [diff] [review]
fix

Ok.
Attachment #634269 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/e828ff0dbc94
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Depends on: 807174
No longer depends on: 807174
You need to log in before you can comment on or make changes to this bug.