Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Create scrollframes for frameset documents

RESOLVED FIXED in mozilla16

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla16
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We might as well. Framesets aren't common, the optimization of avoiding scrollframes is insigificant, and it simplifies things across mobile and desktop and reduces the number of different code paths.
Created attachment 634269 [details] [diff] [review]
fix
Attachment #634269 - Flags: review?(tnikkel)
Comment on attachment 634269 [details] [diff] [review]
fix

I guess content can't do anything silly like create scrollbars by applying an overflow style or something to the root or body element?
It actually can; html.css has "frameset { overflow: -moz-hidden-unscrollable; }", so content can override it. However, I think that's a feature. Note that currently content can add scrollframes to non-root <frameset>s.
Comment on attachment 634269 [details] [diff] [review]
fix

Ok.
Attachment #634269 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/419f0d1b848b
Backed out due to perma orange on Moth, see:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8661c74deeb5

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef1c6a327b0d
This didn't seem to be the cause of the orange. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e828ff0dbc94
https://hg.mozilla.org/mozilla-central/rev/e828ff0dbc94
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Depends on: 807174

Updated

5 years ago
No longer depends on: 807174
You need to log in before you can comment on or make changes to this bug.