766007 - Create scrollframes for frameset documents

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We might as well. Framesets aren't common, the optimization of avoiding scrollframes is insigificant, and it simplifies things across mobile and desktop and reduces the number of different code paths.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 634269 [details] [diff] [review]
fix

I guess content can't do anything silly like create scrollbars by applying an overflow style or something to the root or body element?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It actually can; html.css has "frameset { overflow: -moz-hidden-unscrollable; }", so content can override it. However, I think that's a feature. Note that currently content can add scrollframes to non-root <frameset>s.

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 634269 [details] [diff] [review]
fix

Ok.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/419f0d1b848b

Comment 6

[Mounir Lamouri (:mounir)]

Backed out due to perma orange on Moth, see:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8661c74deeb5

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef1c6a327b0d

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This didn't seem to be the cause of the orange. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e828ff0dbc94

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e828ff0dbc94