766050 - [debugger] ctrl-tab doesn't switch to a new tab when one of the panels is focused

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P3)

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Paul does that happen when the debuggee is paused or even when the debuggee is running?

Comment 2

[Paul Rouget [:paul]]

When the "play" button is pressed.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Joe faced a similar issue in the developer toolbar and fixed it like this:
https://hg.mozilla.org/integration/fx-team/rev/bd9789163a5f

Maybe we are focusing the debugger after a pause and could stop doing that.

Comment 4

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120705 Firefox/15.0a2 (20120705042010)

This is an intermittent issue.

STR:
1. Load a web page in the browser (e.g. http://greensqr.com/misc/mozilla/debugger/).
2. Open the Debugger.
3. Try to use some of the browser specific shortcuts (Ctrl+Tab, Ctrl+T, Ctrl+Shift+A, Ctrl+F etc).
4. Click on the URL bar or tab titlebar to remove the focus from the Debugger. (I also tried clicking on the web page).

Some times no shortcuts work. Other times, with the same STR, all the shortcuts work.

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #3)
> Joe faced a similar issue in the developer toolbar and fixed it like this:
> https://hg.mozilla.org/integration/fx-team/rev/bd9789163a5f
> 
> Maybe we are focusing the debugger after a pause and could stop doing that.

This is definitely the cause.

However, not focusing the debugger after a pause would make all the keyboard shortcuts (including the ones related to stepping) not work, since they're defined in debugger.xul. I believe this is a much bigger issue than not being able to access some browser shortcuts.

And there's always TAB to move the focus back to content or chrome :)

I would mark this bug as WONTFIX, but I'd like to hear other opinions.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I think we are now dynamically attaching the toolbox keybindings to the chrome window when the toolbox opens. Can't we do the same here?

Comment 7

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #6)
> I think we are now dynamically attaching the toolbox keybindings to the
> chrome window when the toolbox opens. Can't we do the same here?

That would probably be a bad idea, since there are too many debugger shortcuts that overlap with default browser shortcuts (e.g. accel+B and accel+shift+B for adding breakpoints vs. opening bookmarks, F6 for resume vs. focusing the awesomebar, F7 for step over vs. turning caret browsing on or off.. it's a long list, I'll stop here).

Comment 8

[Victor Porof [:vporof][:vp]]

Ok!