766051 - [debugger] The "play" button state is confusing

Status: RESOLVED DUPLICATE of bug 893692

(DevTools :: Debugger, defect, P3)

Description

[Paul Rouget [:paul]]

When blue and pressed (which mean "enabled"), it is actually not "playing", but paused. I suggest we go back to the "pause" icon here.

Comment 1

[Victor Porof [:vporof][:vp]]

I think most of the times this button is used to "jump to the next breakpoint". I never actually use it to pause the event loop by myself. However, a "pause" icon is very confusing (at least "play" looks like an arrow that gives me the impression that I can make the script "play" until I hit a new breakpoint).

Maybe we need a completely different icon. Thoughts?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

From the current options, I'm leaning slightly towards the pause icon. A play/pause combo like webkit would be better though.

Comment 3

[Paul Rouget [:paul]]

(In reply to Panos Astithas [:past] from comment #2)
> From the current options, I'm leaning slightly towards the pause icon. A
> play/pause combo like webkit would be better though.

(We have the icons for both.)
Would we have a "checked" status then?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Paul Rouget [:paul] from comment #3)
> (In reply to Panos Astithas [:past] from comment #2)
> > From the current options, I'm leaning slightly towards the pause icon. A
> > play/pause combo like webkit would be better though.
> 
> (We have the icons for both.)

But we need a combined icon for that.

> Would we have a "checked" status then?

I'd say yes. The main purpose of the checkbox style is to alleviate the need for a Paused/Running status label, like we used to have. I think we need the checkbox behavior with any icon.

Comment 5

[Rob Campbell [:rc] (:robcee)]

ok, let's go back to using the Pause button when checked (paused) and play when running.

Comment 6

[Victor Porof [:vporof][:vp]]

Why don't we just reverse the state here and keep the |> icon? Paused should be unchecked ("script's not playing, here's what's happening ...; press me to make it play again"), and unpaused should be checked ("event loop razor is spinning, keep calm and carry on). Just like with a VCR (except most of those have both a |> and a || on the button).

Comment 7

[Rob Campbell [:rc] (:robcee)]

that needs info flag is the worst.

I worry about doing that because it's reversing what we're currently doing and that'll be confusing. Why is this checked now? people will ask. I think if we're going to make a change to the button, we should udpate the icon as well.

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> that needs info flag is the worst.
> 
I was dying to use that flag. I couldn't find a better reason.