Stop conflating effects offset and continuation union size in nsSVGIntegrationUtils

RESOLVED FIXED in mozilla16

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

25.15 KB, patch
Robert Longson
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
More disentanglement from bug 614732, this time to remove the conflation of the concepts of effects offset and continuation union size in nsSVGIntegrationUtils. I found it terribly confusing trying to understand what on earth was going on when SVG terms such as "user space" and "bbox" were being perverted to mean things that they're not. This doesn't completely fix those issues, but it's a decent first pass.
(Assignee)

Comment 1

5 years ago
Created attachment 634423 [details] [diff] [review]
patch
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #634423 - Flags: review?(longsonr)
(Assignee)

Comment 2

5 years ago
Created attachment 634424 [details] [diff] [review]
patch

Sorry, that was the wrong patch.
Attachment #634423 - Attachment is obsolete: true
Attachment #634423 - Flags: review?(longsonr)
Attachment #634424 - Flags: review?(longsonr)

Updated

5 years ago
Attachment #634424 - Flags: review?(longsonr) → review+

Comment 3

5 years ago
nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

r=longsonr either way
(Assignee)

Comment 4

5 years ago
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/d7caec31923e

(In reply to Robert Longson from comment #3)
> nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better
> called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

It's more the size of the context than of a coord, at least to my mind, so I left it as it is. Plus I'm really trying to avoid conflicting queue at the moment.
Target Milestone: --- → mozilla16

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d7caec31923e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.