Closed Bug 766120 Opened 10 years ago Closed 10 years ago

Stop conflating effects offset and continuation union size in nsSVGIntegrationUtils

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file, 1 obsolete file)

More disentanglement from bug 614732, this time to remove the conflation of the concepts of effects offset and continuation union size in nsSVGIntegrationUtils. I found it terribly confusing trying to understand what on earth was going on when SVG terms such as "user space" and "bbox" were being perverted to mean things that they're not. This doesn't completely fix those issues, but it's a decent first pass.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #634423 - Flags: review?(longsonr)
Attached patch patchSplinter Review
Sorry, that was the wrong patch.
Attachment #634423 - Attachment is obsolete: true
Attachment #634423 - Flags: review?(longsonr)
Attachment #634424 - Flags: review?(longsonr)
Attachment #634424 - Flags: review?(longsonr) → review+
nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

r=longsonr either way
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/d7caec31923e

(In reply to Robert Longson from comment #3)
> nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better
> called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

It's more the size of the context than of a coord, at least to my mind, so I left it as it is. Plus I'm really trying to avoid conflicting queue at the moment.
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/d7caec31923e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.