Last Comment Bug 766120 - Stop conflating effects offset and continuation union size in nsSVGIntegrationUtils
: Stop conflating effects offset and continuation union size in nsSVGIntegratio...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jonathan Watt [:jwatt] (back in October - email directly if necessary)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-19 08:05 PDT by Jonathan Watt [:jwatt] (back in October - email directly if necessary)
Modified: 2012-06-20 02:21 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (35.28 KB, patch)
2012-06-19 08:06 PDT, Jonathan Watt [:jwatt] (back in October - email directly if necessary)
no flags Details | Diff | Splinter Review
patch (25.15 KB, patch)
2012-06-19 08:07 PDT, Jonathan Watt [:jwatt] (back in October - email directly if necessary)
longsonr: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-19 08:05:23 PDT
More disentanglement from bug 614732, this time to remove the conflation of the concepts of effects offset and continuation union size in nsSVGIntegrationUtils. I found it terribly confusing trying to understand what on earth was going on when SVG terms such as "user space" and "bbox" were being perverted to mean things that they're not. This doesn't completely fix those issues, but it's a decent first pass.
Comment 1 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-19 08:06:21 PDT
Created attachment 634423 [details] [diff] [review]
patch
Comment 2 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-19 08:07:38 PDT
Created attachment 634424 [details] [diff] [review]
patch

Sorry, that was the wrong patch.
Comment 3 Robert Longson 2012-06-19 08:24:45 PDT
nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

r=longsonr either way
Comment 4 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-19 08:47:53 PDT
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/d7caec31923e

(In reply to Robert Longson from comment #3)
> nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better
> called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

It's more the size of the context than of a coord, at least to my mind, so I left it as it is. Plus I'm really trying to avoid conflicting queue at the moment.
Comment 5 Ed Morley [:emorley] 2012-06-20 02:21:55 PDT
https://hg.mozilla.org/mozilla-central/rev/d7caec31923e

Note You need to log in before you can comment on or make changes to this bug.