766178 - install.rdf fails validation during upload

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Brian King [:kinger]]

I'm trying to upload a new version of one of my add-ons. install.rdf fails to validation, thus it fails. Nothing has changed in install.rdf except the version number, since the last successful upload. It installs and works fine.

Message is:

Your add-on failed validation with 1 error.
Could not parse install.rdf

Here is the XPI:
https://dl.dropbox.com/u/5940796/facebook/facebook1-8-2.xpi

Comment 1

[Matt Basta [:basta]]

This runs fine locally, so it leads me to believe that it's being unpacked wrong on the Zamboni side.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

This is happening for many different add-ons, so it's most likely a server problem.

Comment 3

[Matt Basta [:basta]]

I suspect this to be the cause:

https://github.com/mozilla/zamboni/blob/master/apps/files/utils.py#L395

Can we get a look at the logs?

Comment 4

[Kumar McMillan [:kumar]]

The exception is:

files.utils:ERROR XPI parse error :/data/www/addons.mozilla.org/zamboni/apps/files/utils.py:396#012Traceback (most recent call last):#012  File "/data/www/addons.mozilla.org/zamboni/apps/files/utils.py", line 389, in parse_xpi#012    rdf = Extractor.parse(path)#012  File "/data/www/addons.mozilla.org/zamboni/apps/files/utils.py", line 86, in parse#012    return cls(install_rdf).data#012  File "/data/www/addons.mozilla.org/zamboni/apps/files/utils.py", line 70, in __init__#012    'install.rdf')))#012  File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/rdflib/graph.py", line 757, in parse#012    parser.parse(source, self, **args)#012  File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/rdflib/plugins/parsers/rdfxml.py", line 562, in parse#012    self._parser = create_parser(source, sink)#012  File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/rdflib/plugins/parsers/rdfxml.py", line 540, in create_parser#012    parser = make_parser()#012  File "/usr/lib64/python2.6/xml/sax/__init__.py", line 93, in make_parser#012    raise SAXReaderNotAvailable("No parsers found", None)#012SAXReaderNotAvailable: No parsers found


who knows what it's trying to import though. Seems like some standard module is missing.

Comment 5

[Kumar McMillan [:kumar]]

Looks like we had an unexpected Python upgrade on some servers. Jason is downgrading which should fix it.

Comment 6

[Jason Thomas [:jason]]

Downgraded python on addons nodes to previous version python-2.6.6-29.el6.x86_64. Pinned puppet configuration to this version.

Comment 7

[Kumar McMillan [:kumar]]

Brian, Jorge, did that fix it?

Comment 8

[support]

Working for me now.

Comment 9

[Kumar McMillan [:kumar]]

Thanks, reopen if anyone runs into something

Comment 10

[Brian King [:kinger]]

WFM now as well.

Comment 11

[harryledley]

I'm getting the same problem.

"Your add-on failed validation with 1 error.
Add-on missing install.rdf."

The only thing I changed since my last upload is the version number.  Here is my rdf file if you'd like to see it: http://www.bettercdcs.com/install.rdf

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Have you tried uploading recently?

Comment 13

[harryledley]

I tried a few minutes ago.  That was when I got the error with the rdf file.

Comment 14

[Matt Basta [:basta]]

Can you attach the XPI?

Comment 15

[harryledley]

Attachment: better cdcs xpi file

Comment 16

[Kris Maglione [:kmag]]

That add-on has no install.rdf

Comment 17

[Kumar McMillan [:kumar]]

(In reply to harryledley from comment #11)
> "Your add-on failed validation with 1 error.
> Add-on missing install.rdf."

Hello. This message is not the same as the message originally reported in this bug. "Add-on missing install.rdf" means exactly what it says. I looked at the add-on you attached and indeed it does not have the install.rdf in the right place. It is in a subdirectory but you need to put it in the main directory of the zipped xpi because that's where Firefox looks for it.

If you still have trouble with it after fixing your XPI please open another bug since it is a separate issue.

Comment 18

[harryledley]

Ah, yes.  Thanks.  That fixed the problem.  Sorry for bothering for such a small thing.