766304 - ScopedGfxFeatureReporter uses preference service off the main thread

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

seeing this in the log:
I/Gecko   (  890): ###!!! ASSERTION: Using observer service off the main thread!: 'Error', file /home/blassey/src/mozilla-central/xpcom/ds/nsObserverService.cpp, line 95


not seeing it with this patch

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 634585 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

landed on inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/7bcd7c51ce46 and a follow up to fix windows https://hg.mozilla.org/integration/mozilla-inbound/rev/77804de74060

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7bcd7c51ce46
https://hg.mozilla.org/mozilla-central/rev/77804de74060

Comment 4

[Alex Keybl [:akeybl]]

jst believes this could be exploitable. Approving for Aurora 15 and Beta 14 (tip only, not the release branch).

Comment 5

[Alex Keybl [:akeybl]]

Sending over to you, Brad, since you requested the approval.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bc28779c3dab
https://hg.mozilla.org/releases/mozilla-beta/rev/a93c4915208a
https://hg.mozilla.org/releases/mozilla-aurora/rev/3717bb23ff0f
https://hg.mozilla.org/releases/mozilla-aurora/rev/ca8bf9e97234