Closed Bug 766319 Opened 7 years ago Closed 7 years ago

Move loglines/perfdata definition to __init__ in unittests

Categories

(Testing :: Marionette, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: mdas, Assigned: mdas)

Details

Attachments

(1 file)

Attached patch Fix v0.1Splinter Review
For the marionette test classes we subclass from unittest, we define and add perfdata/loglines in object methods, but we should define these members as part of the object since it makes more sense, and we have seen that when a test fails out, but tries to read these members, but hits an error since they were not defined.

I have attached a tested patch to fix this.
Attachment #634592 - Flags: review?(jgriffin)
Comment on attachment 634592 [details] [diff] [review]
Fix v0.1

Review of attachment 634592 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #634592 - Flags: review?(jgriffin) → review+
http://hg.mozilla.org/mozilla-central/rev/f212d8c913f5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.