move idn code to its own directory, netwerk/dns/idn

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
7 years ago
3 years ago

People

(Reporter: jaas, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 634857 [details] [diff] [review]
fix v1.0

I'd like to move the idn code to its own directory. I'm planning to add quite a bit of code to the netwerk/dns dir and I'd like it to be more cleanly separated. Also, names like nsIIDNService vs. nsIDNSService are very hard to deal with because they are so similar.
Attachment #634857 - Flags: review?(cbiesinger)
Comment on attachment 634857 [details] [diff] [review]
fix v1.0

Instead of adding a new Makefile, could you just prefix the source files with idn/ in the existing Makefile? (I understand the desire for logical separation of code, but more makefiles = a slower build.)
(Reporter)

Comment 3

7 years ago
(In reply to Ted Mielczarek [:ted] from comment #2)

> Instead of adding a new Makefile, could you just prefix the source files
> with idn/ in the existing Makefile? (I understand the desire for logical
> separation of code, but more makefiles = a slower build.)

That's fine with me. I'll make a new patch.
(Reporter)

Comment 4

7 years ago
I'm having trouble using the same makefile - specifically, I can't figure out how to reference the idl files in a sub-directory and have them be processed correctly.
Comment on attachment 634857 [details] [diff] [review]
fix v1.0

r=biesi, once you and ted can work out the build system issues in some way :)
Attachment #634857 - Flags: review?(cbiesinger) → review+

Comment 6

7 years ago
Comment on attachment 634857 [details] [diff] [review]
fix v1.0

Review of attachment 634857 [details] [diff] [review]:
-----------------------------------------------------------------

> I'd like to move the idn code to its own directory

I don't see any of the idn .cpp/.h files moved by this patch? Did I miss something?  Also, please make sure to use "hg copy" to move them, or we'll lose hg history.
(Reporter)

Comment 7

7 years ago
(In reply to Jason Duell (:jduell) from comment #6)

> I don't see any of the idn .cpp/.h files moved by this patch? Did I miss
> something?  Also, please make sure to use "hg copy" to move them, or we'll
> lose hg history.

I think you missed something. I see the cpp/h files hg copied in the patch.

Comment 8

7 years ago
Ah, right--they're in the patch, but don't show up in Bugzilla in either splinter or regular "view patch" mode.   Good to know about that Bugzilla shortcoming...
(Reporter)

Comment 9

7 years ago
I still want this done but it's a huge pain and I'm not planning to spend any more time on it.
Assignee: joshmoz → nobody
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.