766527 - move idn code to its own directory, netwerk/dns/idn

Status: RESOLVED INCOMPLETE

Description

[Josh Aas]

Created attachment 634857 [details] [diff] [review]
fix v1.0

I'd like to move the idn code to its own directory. I'm planning to add quite a bit of code to the netwerk/dns dir and I'd like it to be more cleanly separated. Also, names like nsIIDNService vs. nsIDNSService are very hard to deal with because they are so similar.

Comment 1

[Josh Aas]

try server run:

https://tbpl.mozilla.org/?tree=Try&rev=72dba8ea9332

Comment 2

[Ted Mielczarek [:ted] [:ted.mielczarek]]

Comment on attachment 634857 [details] [diff] [review]
fix v1.0

Instead of adding a new Makefile, could you just prefix the source files with idn/ in the existing Makefile? (I understand the desire for logical separation of code, but more makefiles = a slower build.)

Comment 3

[Josh Aas]

(In reply to Ted Mielczarek [:ted] from comment #2)

> Instead of adding a new Makefile, could you just prefix the source files
> with idn/ in the existing Makefile? (I understand the desire for logical
> separation of code, but more makefiles = a slower build.)

That's fine with me. I'll make a new patch.

Comment 4

[Josh Aas]

I'm having trouble using the same makefile - specifically, I can't figure out how to reference the idl files in a sub-directory and have them be processed correctly.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 634857 [details] [diff] [review]
fix v1.0

r=biesi, once you and ted can work out the build system issues in some way :)

Comment 6

[Jason Duell]

Comment on attachment 634857 [details] [diff] [review]
fix v1.0

Review of attachment 634857 [details] [diff] [review]:
-----------------------------------------------------------------

> I'd like to move the idn code to its own directory

I don't see any of the idn .cpp/.h files moved by this patch? Did I miss something?  Also, please make sure to use "hg copy" to move them, or we'll lose hg history.

Comment 7

[Josh Aas]

(In reply to Jason Duell (:jduell) from comment #6)

> I don't see any of the idn .cpp/.h files moved by this patch? Did I miss
> something?  Also, please make sure to use "hg copy" to move them, or we'll
> lose hg history.

I think you missed something. I see the cpp/h files hg copied in the patch.

Comment 8

[Jason Duell]

Ah, right--they're in the patch, but don't show up in Bugzilla in either splinter or regular "view patch" mode.   Good to know about that Bugzilla shortcoming...

Comment 9

[Josh Aas]

I still want this done but it's a huge pain and I'm not planning to spend any more time on it.