76654 - ActiveX control does not use profiles

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The ActiveX control doesn't set a default profile at startup which can lead to 
problems with the cache and other areas. Put some code into the initialisation 
routines to set the profile.

Comment 1

[Adam Lock]

Attachment: Patch adds profile selection to initialisation. Currently it's hardcoded to "MozillaControl" but it could be made selectable later on.

Comment 2

[Adam Lock]

Submitting for 0.9 approval

Comment 3

[Christopher Blizzard (:blizzard)]

What happens if the MozillaControl profile already exists?  I see that you
always try to create it.

Comment 4

[Adam Lock]

Good point, I thought the method didn't do anything if it already existed. 
Second patch coming will fix that

Comment 5

[Adam Lock]

Attachment: Patch fixes the profile already exists problem

Comment 6

[Christopher Blizzard (:blizzard)]

r/sr/a=blizzard for 0.9

You should find another rubber stamping reviewer, though.

Comment 7

[Conrad Carlen (not reading bugmail)]

r=ccarlen. I'd still encourage checking out what gtkWidget does with a
directoryServiceProvider. It's low overhead, you can control where the "profile"
dir is easily and it won't add profiles to mozilla.

Comment 8

[Adam Lock]

Fix is checked in.

I have opened bug 76654 to deal with the broader issue of which profile 
mechanism is right for the control.

Comment 9

[Adam Lock]

Oops, I meant bug 76664